You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "jengebr (via GitHub)" <gi...@apache.org> on 2025/04/25 18:25:09 UTC
[PR] Adding nonstandard catch, if, choose/when/otherwise [tomcat]
jengebr opened a new pull request, #845:
URL: https://github.com/apache/tomcat/pull/845
Adds non-standard implementations of `c:catch`, `c:if`, `c:choose`, `c:when`, and `c:otherwise`. Note that incorrectly structured choose/when/otherwise combinations are blocked by the tag lib validation, so an entire class of edge cases does not need to be supported or tested.
Along the way I cleaned up the code into implementations of a new interface `NonstandardCustomTagGenerator`. Application owners cannot yet create their own overrides (exposing fields is problematic) but this organizes the now-seven tag implementations and is a step in the right direction to open it up.
When activated, these changes eliminate the vast majority of tags on my application's JSPs, with impressive performance results. I have no immediate plans to support other tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Adding nonstandard catch, if, choose/when/otherwise [tomcat]
Posted by "jengebr (via GitHub)" <gi...@apache.org>.
jengebr closed pull request #845: Adding nonstandard catch, if, choose/when/otherwise
URL: https://github.com/apache/tomcat/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Adding nonstandard catch, if, choose/when/otherwise [tomcat]
Posted by "jengebr (via GitHub)" <gi...@apache.org>.
jengebr commented on PR #845:
URL: https://github.com/apache/tomcat/pull/845#issuecomment-2845602223
Found some significant bugs, need to rework. Closing w/o merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org