[GitHub] [superset] stephenLYZ commented on a diff in pull request #20095: fix(database): make to display validation error msg when all cases

[GitBox <gi...@apache.org>]

stephenLYZ commented on code in PR #20095:
URL: https://github.com/apache/superset/pull/20095#discussion_r875028455


##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -1088,7 +1088,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
     let alertErrors: string[] = [];
     if (isEmpty(dbErrors) === false) {
       alertErrors = typeof dbErrors === 'object' ? Object.values(dbErrors) : [];
-    } else if (db?.engine === Engines.Snowflake) {
+    } else if (isEmpty(validationErrors) === false) {

Review Comment:
   looks like `!isEmpty(validationErrors)` is more cleaner. So I'm curious that why we need to remove d`b?.engine === Engines.Snowflake` condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org