[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5209: GEODE-8211: fix flaky shutdown test

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434814571



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,11 +61,7 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
 
     // Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
     // returns an error.
-    try {
-      jedis.shutdown();
-    } catch (JedisConnectionException ignore) {

Review comment:
       It was throwing this before, intermittently, because the server was actually shutting down intermittently. The point of the test was for shutdown to be a NOOP. But the flag the test sets to make it a noop did not work because the thread reading the flag is in another thread so it sometimes did not see that the command was unsupported. So now with the "volatile" on the boolean, it will always see the change this test makes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org