You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Kristian Rosenvold <kr...@apache.org> on 2015/11/25 06:44:39 UTC
[VOTE] Release commons-io 2.5 based on RC1 - Cancelled
Thanks for the reviews, I'll fix the reported problems and respin!
the test failure on java8 site looks weird, I'll look into that.
As for actually publishing the site on java8, I'd have to switch to
the google BCEL to fix that. I'm assuming we can just "not support"
this for the time being ?
Kristian
2015-11-25 2:36 GMT+01:00 Gary Gregory <ga...@gmail.com>:
> Just to add to Java 8 woes, running "mvn clean site", I get:
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 08:01 min
> [INFO] Finished at: 2015-11-24T16:13:48-08:00
> [INFO] Final Memory: 62M/540M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on
> project commons-io: Execution default-site of goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site failed: Invalid byte
> tag in constant pool: 15
> -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
>
> Using:
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.8.0_65, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_65\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>
> It probably has nothing to do with us, just a data point.
>
> This is from the src zip, ASC, MD5, SHA1, and reports are OK.
>
> I can build with "mvn clean site" OK with:
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> So +1 from me based on my experience. I am worried about the report
> failures on the VOTE thread though. I did not install/run with Java 6
> though.
>
> Caveat, while in the Cobertura part of the build, I saw this:
>
> Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 26.076 sec
> <<< FAILURE! - in org.apache.commons.io.input.TailerTest
> testTailer(org.apache.commons.io.input.TailerTest) Time elapsed: 5.412 sec
> <<< FAILURE!
> junit.framework.AssertionFailedError: Missing InterruptedException
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.assertTrue(Assert.java:22)
> at junit.framework.Assert.assertNotNull(Assert.java:256)
> at junit.framework.TestCase.assertNotNull(TestCase.java:426)
> at
> org.apache.commons.io.input.TailerTest.testTailer(TailerTest.java:258)
>
> But I did not see the above during the normal test phase of the build.
>
> Gary
>
> On Tue, Nov 24, 2015 at 12:59 PM, Oliver Heger <oliver.heger@oliver-heger.de
>> wrote:
>
>> Hi Kristian,
>>
>> while checking the release I found some problems:
>>
>> * The commons-io-2.5.jar in the binary distribution contains a
>> cobertura.properties file. This is probably created by running the site
>> build over the release build before creating the distributions. In the
>> past we had a problematic release because Cobertura seems to mess up
>> some classes. I cannot remember the exact details, but the jar was not
>> working correctly. Could this be the case here, too?
>> * The copyright year in NOTICE is still 2014. I think this is blocking.
>> * Building with Java 1.6 on Windows 10 gives a test failure:
>>
>>
>> -------------------------------------------------------------------------------
>> Test set: org.apache.commons.io.FileUtilsTestCase
>>
>> -------------------------------------------------------------------------------
>> Tests run: 134, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.203
>> sec <<< FAILURE! - in org.apache.commons.io.FileUtilsTestCase
>> testGetFile(org.apache.commons.io.FileUtilsTestCase) Time elapsed: 0
>> sec <<< ERROR!
>> java.io.IOException: Cannot create file
>>
>> C:\data\dev\projects\OpenSource\io\commons-io-2.5-src\test\io\file1-test.txt
>> as the parent directory does not exist
>> at
>>
>> org.apache.commons.io.testtools.FileBasedTestCase.createFile(FileBasedTestCase.java:60)
>> at
>> org.apache.commons.io.FileUtilsTestCase.setUp(FileUtilsTestCase.java:101)
>>
>> With Java 1.8 it is worse; here I get 71 errors which are mostly similar
>> to the one before (all in FileUtilsTestCase).
>>
>> The site looks okay except for the JIRA report which is missing.
>>
>> -1
>>
>> Sorry
>> Oliver
>>
>>
>> Am 23.11.2015 um 18:31 schrieb Kristian Rosenvold:
>> > We have fixed quite a few bugs and added some significant
>> > enhancements since commons-io was released,
>> > so I would like to release commons-io 2.5
>> >
>> > Foo 2.5 RC1 is available for review here:
>> > https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision
>> 11266)
>> >
>> > Maven artifacts are here:
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1123
>> >
>> > Details of changes since 2.4 are in the release notes:
>> > https://dist.apache.org/repos/dist/dev/commons/io/RELEASE-NOTES.txt
>> >
>> http://people.apache.org/~krosenvold/commons-io-2.5-RC1/changes-report.html
>> >
>> > I have tested this with JDK 1.6, 1.7 and 1.8.
>> >
>> > The tag is here:
>> >
>> https://svn.apache.org/repos/asf/commons/proper/io/tags/commons-io-2.5-RC1
>> > (r1715890)
>> >
>> > Site:
>> > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/
>> > (note some *relative* links are broken and the 2.5 directories are
>> > not yet created - these will be OK once the site is deployed)
>> >
>> > Clirr Report (compared to 2.4):
>> >
>> http://people.apache.org/~krosenvold/commons-io-2.5-RC1/clirr-report.html
>> >
>> >
>> > RAT Report:
>> >
>> http://people.apache.org/~krosenvold/commons-io-2.5-RC1/rat-report.html
>> >
>> > KEYS:
>> > https://www.apache.org/dist/commons/KEYS
>> >
>> > Please review the release candidate and vote.
>> > This vote will close no sooner that 72 hours from now, i.e. after
>> > 19:00 CET 26-March 2015
>> >
>> > [ ] +1 Release these artifacts
>> > [ ] +0 OK, but...
>> > [ ] -0 OK, but really should fix...
>> > [ ] -1 I oppose this release because...
>> >
>> > Thanks!
>> >
>> >
>> > Kristian
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org