You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "hudeqi (via GitHub)" <gi...@apache.org> on 2023/05/10 03:45:26 UTC
[GitHub] [kafka] hudeqi opened a new pull request, #13697: MINOR:code optimization in QuorumController
hudeqi opened a new pull request, #13697:
URL: https://github.com/apache/kafka/pull/13697
1. add hint in switch item "BROKER_LOGGER" in ConfigResourceExistenceChecker, otherwise, it will be classified as default break and deleted directly. I don’t know if adding hint is better than deleting directly.
2. delete some unused variables and methods.
3. add the "@Disabled" mark to a method in unit test that is not tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming merged pull request #13697: MINOR:code optimization in QuorumController
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming merged PR #13697:
URL: https://github.com/apache/kafka/pull/13697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a diff in pull request #13697: MINOR:code optimization in QuorumController
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1190566126
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
}
}
+ @Disabled
Review Comment:
I guess it was removed accidentally since there are no related discussion about this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a diff in pull request #13697: MINOR:code optimization in QuorumController
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1191937851
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1586,11 +1578,6 @@ private void resetToEmptyState() {
*/
private final FaultHandler fatalFaultHandler;
- /**
- * The slf4j log context, used to create new loggers.
- */
- private final LogContext logContext;
Review Comment:
I think we can remove it for now, if we want to use it in the future in other component, such as `BrokerHeartbeatManager`, we can add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on a diff in pull request #13697: MINOR:code optimization in QuorumController
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1189682174
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
}
}
+ @Disabled
Review Comment:
> I think we forgot a `@Test` here.
thanks your reply.
I saw that there was a “@Test” annotation before, but it was removed at this [commit](https://github.com/apache/kafka/commit/8c88cdb7186b1d594f991eb324356dcfcabdf18a). I wonder if it was intentional? @dengziming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on a diff in pull request #13697: MINOR:code optimization in QuorumController
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1191942365
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1586,11 +1578,6 @@ private void resetToEmptyState() {
*/
private final FaultHandler fatalFaultHandler;
- /**
- * The slf4j log context, used to create new loggers.
- */
- private final LogContext logContext;
Review Comment:
ok, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on a diff in pull request #13697: MINOR:code optimization in QuorumController
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1190576044
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
}
}
+ @Disabled
Review Comment:
> I guess it was removed accidentally since there are no related discussion about this change.
Ok thanks, I've fixed it. @dengziming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a diff in pull request #13697: MINOR:code optimization in QuorumController
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1189676045
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
}
}
+ @Disabled
Review Comment:
I think we forgot a `@Test` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org