You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/30 08:56:26 UTC

[GitHub] [flink] zhuzhurk commented on a diff in pull request #20087: [FLINK-28271][runtime] Add config options for speculative scheduler

zhuzhurk commented on code in PR #20087:
URL: https://github.com/apache/flink/pull/20087#discussion_r910779628


##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -593,6 +593,40 @@ public enum SchedulerType {
                                             code(SchedulerType.AdaptiveBatch.name()))
                                     .build());
 
+    @Documentation.Section({
+        Documentation.Sections.EXPERT_SCHEDULING,
+        Documentation.Sections.ALL_JOB_MANAGER
+    })
+    public static final ConfigOption<Boolean> SPECULATIVE_ENABLED =

Review Comment:
   I prefer to keep the option name not too long, as long as the we can identify it is part of speculative execution.
   I will rename `BLOCK_SLOW_NODE_DURATION` to `SPECULATIVE_BLOCK_SLOW_NODE_DURATION`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org