[jira] [Resolved] (HBASE-25759) The master services field in LocalityBasedCostFunction is never used

["Duo Zhang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-25759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-25759.
-------------------------------
    Fix Version/s: 2.3.6
                   2.4.3
                   2.5.0
                   3.0.0-alpha-1
     Hadoop Flags: Reviewed
       Resolution: Fixed

Pushed to branch-2.3+.

Thanks [~niuyulin] for reviewing.

> The master services field in LocalityBasedCostFunction is never used
> --------------------------------------------------------------------
>
>                 Key: HBASE-25759
>                 URL: https://issues.apache.org/jira/browse/HBASE-25759
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3, 2.3.6
>
>
> We just use it to test whether we should do the calculation.
> But in fact, it should never be null when we arrive here. Maybe it is because in test we may skip setting the master services but I think we should just skip balancing in the balancer, not in the cost function.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)