You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2013/10/04 23:33:23 UTC

Review Request 14496: Patch for KAFKA-1073

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1073
    https://issues.apache.org/jira/browse/KAFKA-1073


Repository: kafka


Description
-------

kafka-1017


Diffs
-----

  core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 

Diff: https://reviews.apache.org/r/14496/diff/


Testing
-------


Thanks,

Jun Rao


Re: Review Request 14496: incorporating review feedback

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26717
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Oct. 5, 2013, 6:02 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 6:02 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017; incorporating review feedback
> 
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   bin/kafka-check-reassignment-status.sh 1f218585cddddb8bf58d8a85af38f368a49b27e5 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14496: incorporating review feedback

Posted by Guozhang Wang <gu...@linkedin.com>.

> On Oct. 6, 2013, 8 p.m., Swapnil Ghike wrote:
> > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 61-65
> > <https://reviews.apache.org/r/14496/diff/2/?file=361683#file361683line61>
> >
> >     Instead of asking the user to store the output of a dryrun into a JSON file, should the tool compute the dryrun output and use it to perform validation ?
> 
> Neha Narkhede wrote:
>     That would be a better experience and since only one reassignment operation can ever be in progress, this could've been possible by reading the reassignment zookeeper path. However, we can't reliably do that right now since we overwrite that path when reassignment is completed. Ideally, if we can avoid rewriting that and report progress for the reassignment operation, it would be a better tooling experience. Probably we can fix that in a separate JIRA?

Another possible way is to not returning until the topic partitions zk path has reflected the change, i.e. the checkIfReassignmentSucceeded has passed. 


- Guozhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26714
-----------------------------------------------------------


On Oct. 5, 2013, 6:02 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 6:02 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017; incorporating review feedback
> 
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   bin/kafka-check-reassignment-status.sh 1f218585cddddb8bf58d8a85af38f368a49b27e5 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14496: incorporating review feedback

Posted by Neha Narkhede <ne...@gmail.com>.

> On Oct. 6, 2013, 8 p.m., Swapnil Ghike wrote:
> > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 61-65
> > <https://reviews.apache.org/r/14496/diff/2/?file=361683#file361683line61>
> >
> >     Instead of asking the user to store the output of a dryrun into a JSON file, should the tool compute the dryrun output and use it to perform validation ?

That would be a better experience and since only one reassignment operation can ever be in progress, this could've been possible by reading the reassignment zookeeper path. However, we can't reliably do that right now since we overwrite that path when reassignment is completed. Ideally, if we can avoid rewriting that and report progress for the reassignment operation, it would be a better tooling experience. Probably we can fix that in a separate JIRA?


- Neha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26714
-----------------------------------------------------------


On Oct. 5, 2013, 6:02 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 6:02 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017; incorporating review feedback
> 
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   bin/kafka-check-reassignment-status.sh 1f218585cddddb8bf58d8a85af38f368a49b27e5 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14496: incorporating review feedback

Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26714
-----------------------------------------------------------



core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
<https://reviews.apache.org/r/14496/#comment52036>

    Instead of asking the user to store the output of a dryrun into a JSON file, should the tool compute the dryrun output and use it to perform validation ?


- Swapnil Ghike


On Oct. 5, 2013, 6:02 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 6:02 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017; incorporating review feedback
> 
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   bin/kafka-check-reassignment-status.sh 1f218585cddddb8bf58d8a85af38f368a49b27e5 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14496: incorporating review feedback

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/
-----------------------------------------------------------

(Updated Oct. 5, 2013, 6:02 p.m.)


Review request for kafka.


Summary (updated)
-----------------

incorporating review feedback


Bugs: KAFKA-1073
    https://issues.apache.org/jira/browse/KAFKA-1073


Repository: kafka


Description (updated)
-------

kafka-1017; incorporating review feedback


kafka-1017


Diffs (updated)
-----

  bin/kafka-check-reassignment-status.sh 1f218585cddddb8bf58d8a85af38f368a49b27e5 
  core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 

Diff: https://reviews.apache.org/r/14496/diff/


Testing
-------


Thanks,

Jun Rao


Re: Review Request 14496: Patch for KAFKA-1073

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26704
-----------------------------------------------------------


Thanks for the patch. I also think deprecating this and adding a --validate option to the reassign partitions tool is a good idea.

- Neha Narkhede


On Oct. 4, 2013, 9:33 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 9:33 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14496: Patch for KAFKA-1073

Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26701
-----------------------------------------------------------

Ship it!


Do you think incorporating this functionality in the ReassignPartitions tool itself with a "checkStatus" mode make sense in trunk?

- Swapnil Ghike


On Oct. 4, 2013, 9:33 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 9:33 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14496: Patch for KAFKA-1073

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14496/#review26703
-----------------------------------------------------------

Ship it!


Agree with Swapnil.

- Guozhang Wang


On Oct. 4, 2013, 9:33 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14496/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 9:33 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1073
>     https://issues.apache.org/jira/browse/KAFKA-1073
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1017
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/CheckReassignmentStatus.scala 7e85f87e96dbddf4fd8785ae3960e8fe4813e8e5 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala f333d29bf36bb7fdc66b3bf9af16e7ee19ad7e48 
> 
> Diff: https://reviews.apache.org/r/14496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>