You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/12 15:51:21 UTC

[GitHub] [spark] gengliangwang opened a new pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

gengliangwang opened a new pull request #33729:
URL: https://github.com/apache/spark/pull/33729


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Test the following valid operations:
   ```
   interval * null
   null * interval
   interval / null
   ```
   and invalid operations:
   ```
   null / interval
   int / interval
   ```
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Improve test coverage
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898307475


   **[Test build #142413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142413/testReport)** for PR 33729 at commit [`36a820c`](https://github.com/apache/spark/commit/36a820c73da055767a1d48cca369158b2843c780).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898274592


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688273548



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -117,6 +117,75 @@ struct<(INTERVAL '02' SECOND * NULL):interval day to second>
 NULL
 
 
+-- !query
+select interval '2 year' / 0
+-- !query schema
+struct<>
+-- !query output
+java.lang.ArithmeticException
+/ by zero
+
+
+-- !query
+select interval '2 year' / null
+-- !query schema
+struct<(INTERVAL '2' YEAR / NULL):interval year to month>

Review comment:
       I am ok to fix this in a separate PR. @gengliangwang Could you open a sub-task in https://issues.apache.org/jira/browse/SPARK-27790, please.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897815476


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142389/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898185733


   **[Test build #142413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142413/testReport)** for PR 33729 at commit [`36a820c`](https://github.com/apache/spark/commit/36a820c73da055767a1d48cca369158b2843c780).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688262216



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -117,6 +117,75 @@ struct<(INTERVAL '02' SECOND * NULL):interval day to second>
 NULL
 
 
+-- !query
+select interval '2 year' / 0
+-- !query schema
+struct<>
+-- !query output
+java.lang.ArithmeticException
+/ by zero
+
+
+-- !query
+select interval '2 year' / null
+-- !query schema
+struct<(INTERVAL '2' YEAR / NULL):interval year to month>

Review comment:
       good point. This is probably something we should fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688289970



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -117,6 +117,75 @@ struct<(INTERVAL '02' SECOND * NULL):interval day to second>
 NULL
 
 
+-- !query
+select interval '2 year' / 0
+-- !query schema
+struct<>
+-- !query output
+java.lang.ArithmeticException
+/ by zero
+
+
+-- !query
+select interval '2 year' / null
+-- !query schema
+struct<(INTERVAL '2' YEAR / NULL):interval year to month>

Review comment:
       It's to have a wider data type as the division result. Just like the following
   ```
   scala> spark.sql("select 1 /null")
   res0: org.apache.spark.sql.DataFrame = [(1 / NULL): double]
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688274200



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -16,6 +16,16 @@ select interval '2 seconds' / 0;
 select interval '2 seconds' / null;
 select interval '2 seconds' * null;
 select null * interval '2 seconds';
+select interval '2 year' / 0;
+select interval '2 year' / null;
+select interval '2 year' * null;
+select null * interval '2 year';

Review comment:
       Done, updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897815196


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46896/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898219426


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46919/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898268911


   +1, LGTM. Merging to master/3.2.
   Thank you, @gengliangwang and @cloud-fan for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688277442



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -117,6 +117,75 @@ struct<(INTERVAL '02' SECOND * NULL):interval day to second>
 NULL
 
 
+-- !query
+select interval '2 year' / 0
+-- !query schema
+struct<>
+-- !query output
+java.lang.ArithmeticException
+/ by zero
+
+
+-- !query
+select interval '2 year' / null
+-- !query schema
+struct<(INTERVAL '2' YEAR / NULL):interval year to month>

Review comment:
       This is the data type of `DivideYMInterval`, which is the default YM interval type.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688292125



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -117,6 +117,75 @@ struct<(INTERVAL '02' SECOND * NULL):interval day to second>
 NULL
 
 
+-- !query
+select interval '2 year' / 0
+-- !query schema
+struct<>
+-- !query output
+java.lang.ArithmeticException
+/ by zero
+
+
+-- !query
+select interval '2 year' / null
+-- !query schema
+struct<(INTERVAL '2' YEAR / NULL):interval year to month>

Review comment:
       Got it. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688257781



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -16,6 +16,16 @@ select interval '2 seconds' / 0;
 select interval '2 seconds' / null;
 select interval '2 seconds' * null;
 select null * interval '2 seconds';
+select interval '2 year' / 0;
+select interval '2 year' / null;
+select interval '2 year' * null;
+select null * interval '2 year';

Review comment:
       Can you check interval in ANSI style at least once: `interval '2' year`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898185733


   **[Test build #142413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142413/testReport)** for PR 33729 at commit [`36a820c`](https://github.com/apache/spark/commit/36a820c73da055767a1d48cca369158b2843c780).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688257781



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -16,6 +16,16 @@ select interval '2 seconds' / 0;
 select interval '2 seconds' / null;
 select interval '2 seconds' * null;
 select null * interval '2 seconds';
+select interval '2 year' / 0;
+select interval '2 year' / null;
+select interval '2 year' * null;
+select null * interval '2 year';

Review comment:
       Can you check interval in ANSI style at least once: `interval '2' year` in regular (normal) case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898309654


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142413/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688255881



##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -117,6 +117,75 @@ struct<(INTERVAL '02' SECOND * NULL):interval day to second>
 NULL
 
 
+-- !query
+select interval '2 year' / 0
+-- !query schema
+struct<>
+-- !query output
+java.lang.ArithmeticException
+/ by zero
+
+
+-- !query
+select interval '2 year' / null
+-- !query schema
+struct<(INTERVAL '2' YEAR / NULL):interval year to month>

Review comment:
       I wonder why the type is `interval year to month` but not `interval year`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897815196






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898274592


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898272547


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #33729:
URL: https://github.com/apache/spark/pull/33729


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898224863


   **[Test build #142418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142418/testReport)** for PR 33729 at commit [`b5d974d`](https://github.com/apache/spark/commit/b5d974d3a86fc59c3a2f1e2a072685a55cc09dff).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898219426


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46919/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897810645


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46896/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898392774


   **[Test build #142418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142418/testReport)** for PR 33729 at commit [`b5d974d`](https://github.com/apache/spark/commit/b5d974d3a86fc59c3a2f1e2a072685a55cc09dff).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898224863


   **[Test build #142418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142418/testReport)** for PR 33729 at commit [`b5d974d`](https://github.com/apache/spark/commit/b5d974d3a86fc59c3a2f1e2a072685a55cc09dff).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897814919


   **[Test build #142389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142389/testReport)** for PR 33729 at commit [`c6efc82`](https://github.com/apache/spark/commit/c6efc82481e5a625f77d1e6b71e71d86b198ef2b).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898309654


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142413/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897770126


   **[Test build #142389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142389/testReport)** for PR 33729 at commit [`c6efc82`](https://github.com/apache/spark/commit/c6efc82481e5a625f77d1e6b71e71d86b198ef2b).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898393897


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142418/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898251746


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898199388


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46919/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-898219402


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46919/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688236380



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -170,6 +170,21 @@ select
   null - interval '2' year,
   null + interval '2' hour,
   null - interval '2' hour;
+select

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33729:
URL: https://github.com/apache/spark/pull/33729#issuecomment-897770126


   **[Test build #142389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142389/testReport)** for PR 33729 at commit [`c6efc82`](https://github.com/apache/spark/commit/c6efc82481e5a625f77d1e6b71e71d86b198ef2b).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33729: [SPARK-36499][SQL][TESTS] Test Interval multiply / divide null

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33729:
URL: https://github.com/apache/spark/pull/33729#discussion_r688217565



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -170,6 +170,21 @@ select
   null - interval '2' year,
   null + interval '2' hour,
   null - interval '2' hour;
+select

Review comment:
       there is a section at the beginning of this file `-- multiply and divide an interval by a number`. Can we put the null tests there?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org