You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/29 16:25:37 UTC
[PR] [ISSUE #2759] fix(metrics): sanitize mini bar metric samples [rocketmq-dashboard]
yuluo-yx opened a new pull request, #2779:
URL: https://github.com/apache/rocketmq-dashboard/pull/2779
## Summary
- normalize non-finite and negative MiniBar samples before calculating dimensions
- keep generated CSS heights and the default accessible label finite
- cover malformed and valid metric samples with a focused component test
## Verification
- MiniBar.test.tsx: 3 tests passed
- npm run build passed
- targeted ESLint and Prettier checks passed
- scope check: 19 changed lines
Fixes #2759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #2759] fix(metrics): sanitize mini bar metric samples [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2779: [ISSUE #2759] fix(metrics): sanitize mini bar metric samples
URL: https://github.com/apache/rocketmq-dashboard/pull/2779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #2759] fix(metrics): sanitize mini bar metric samples [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2779:
URL: https://github.com/apache/rocketmq-dashboard/pull/2779#issuecomment-5477548032
Closing: these patches defend against inputs that cannot occur (e.g., JSON payloads cannot carry NaN/Infinity, and backend-produced fields do not contain stray whitespace). The linked issues were self-filed minutes before the PRs were opened. If you have observed a real defect, please provide reproduction steps or logs, and submit one cohesive PR per functional domain. See the maintainer note on #2724.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org