You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/10/20 17:19:49 UTC
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #6839: Fixed NPE on volume creation from snapshot
JoaoJandre opened a new pull request, #6839:
URL: https://github.com/apache/cloudstack/pull/6839
### Description
This PR fixes a NPE that occurs when trying to create a volume from a snapshot. This happens because when trying to log the `virtualMachineProfile` in the `AbstractStoragePoolAllocator#logStartOfSearch` method, its `toString()` method will throw a NPE since the `_vm` attribute is null.
Some `toString()`s were also created in classes that had objects being logged during the volume creation process, as they were being logged as memory addresses since they had no `toString()` implementation.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
This was tested in a local lab, before this patch every time I tried to create a volume from a snapshot, a NPE was thrown. After the patch the volume creation from snapshot was fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1287181046
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6839 (SL-JID-2542)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#discussion_r1002077253
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java:
##########
@@ -107,7 +107,7 @@ protected List<StoragePool> select(DiskProfile dskCh, VirtualMachineProfile vmPr
}
}
- s_logger.debug(String.format("ClusterScopeStoragePoolAllocator is returning [%s] suitable storage pools [%s].", suitablePools.size(), suitablePools));
+ logEndOfSearch(suitablePools);
Review Comment:
I know it. I just think it is unnecessary. it will not bring any benefit I think.
on the contrary, if I get log "ClusterScopeStoragePoolAllocator is returning xxx" and grep in source code, the result will be empty.
ps: this does not mean -1 to this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1287175180
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1287235045
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6839)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6839&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6839&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6839&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1287175839
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#discussion_r1001499713
##########
engine/components-api/src/main/java/com/cloud/vm/VirtualMachineProfileImpl.java:
##########
@@ -86,7 +86,10 @@ public VirtualMachineProfileImpl(VirtualMachine.Type type) {
@Override
public String toString() {
- return _vm.toString();
+ if (_vm != null) {
+ return _vm.toString();
+ }
+ return null;
Review Comment:
```suggestion
return "";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1288069709
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1288069896
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#discussion_r1001459067
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java:
##########
@@ -107,7 +107,7 @@ protected List<StoragePool> select(DiskProfile dskCh, VirtualMachineProfile vmPr
}
}
- s_logger.debug(String.format("ClusterScopeStoragePoolAllocator is returning [%s] suitable storage pools [%s].", suitablePools.size(), suitablePools));
+ logEndOfSearch(suitablePools);
Review Comment:
code lgtm
however, I like the old style more than the new method `logEndOfSearch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on code in PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#discussion_r1001966670
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java:
##########
@@ -107,7 +107,7 @@ protected List<StoragePool> select(DiskProfile dskCh, VirtualMachineProfile vmPr
}
}
- s_logger.debug(String.format("ClusterScopeStoragePoolAllocator is returning [%s] suitable storage pools [%s].", suitablePools.size(), suitablePools));
+ logEndOfSearch(suitablePools);
Review Comment:
The problem with the old style is that it repeats the same code in 4 different classes, the only difference is the first word in the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1288082866
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1288523683
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1285977546
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6839)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6839&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6839&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6839&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6839&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6839&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
JoaoJandre commented on code in PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#discussion_r1001966670
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java:
##########
@@ -107,7 +107,7 @@ protected List<StoragePool> select(DiskProfile dskCh, VirtualMachineProfile vmPr
}
}
- s_logger.debug(String.format("ClusterScopeStoragePoolAllocator is returning [%s] suitable storage pools [%s].", suitablePools.size(), suitablePools));
+ logEndOfSearch(suitablePools);
Review Comment:
The problem with the old style is that it repeats the same code in 4 different classes, the only difference is the first word in the String.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1285952397
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6839](https://codecov.io/gh/apache/cloudstack/pull/6839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8519e2b) into [main](https://codecov.io/gh/apache/cloudstack/commit/17fe98432daa0f1c67414c6ea69efa56eb30e195?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17fe984) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6839 +/- ##
=========================================
Coverage 10.80% 10.81%
- Complexity 7082 7083 +1
=========================================
Files 2485 2485
Lines 245355 245363 +8
Branches 38314 38314
=========================================
+ Hits 26518 26525 +7
Misses 215576 215576
- Partials 3261 3262 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/vm/VirtualMachineProfileImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1ZpcnR1YWxNYWNoaW5lUHJvZmlsZUltcGwuamF2YQ==) | `36.44% <0.00%> (-0.70%)` | :arrow_down: |
| [...stack/engine/orchestration/VolumeOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...torage/allocator/AbstractStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvQWJzdHJhY3RTdG9yYWdlUG9vbEFsbG9jYXRvci5qYXZh) | `8.88% <0.00%> (-0.16%)` | :arrow_down: |
| [...ge/allocator/ClusterScopeStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvQ2x1c3RlclNjb3BlU3RvcmFnZVBvb2xBbGxvY2F0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...k/storage/allocator/LocalStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvTG9jYWxTdG9yYWdlUG9vbEFsbG9jYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...torage/allocator/ZoneWideStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9hbGxvY2F0b3IvWm9uZVdpZGVTdG9yYWdlUG9vbEFsbG9jYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dstack/storage/datastore/PrimaryDataStoreImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvdm9sdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL1ByaW1hcnlEYXRhU3RvcmVJbXBsLmphdmE=) | `2.23% <0.00%> (-0.02%)` | :arrow_down: |
| [.../storage/allocator/RandomStoragePoolAllocator.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlLWFsbG9jYXRvcnMvcmFuZG9tL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvYWxsb2NhdG9yL1JhbmRvbVN0b3JhZ2VQb29sQWxsb2NhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...om/cloud/deploy/DeploymentPlanningManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5pbmdNYW5hZ2VySW1wbC5qYXZh) | `28.05% <0.00%> (+0.76%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1288523339
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6839: Fixed NPE on volume creation from snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#issuecomment-1289415064
<b>Trillian test result (tid-5191)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6839-t5191-kvm-centos7.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org