You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/09/16 09:29:17 UTC
[GitHub] [skywalking] JaredTan95 commented on a change in pull request
#3367: agent support custom properties.
JaredTan95 commented on a change in pull request #3367: agent support custom properties.
URL: https://github.com/apache/skywalking/pull/3367#discussion_r324579792
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/ServiceAndEndpointRegisterClient.java
##########
@@ -58,6 +60,7 @@
public class ServiceAndEndpointRegisterClient implements BootService, Runnable, GRPCChannelListener {
private static final ILog logger = LogManager.getLogger(ServiceAndEndpointRegisterClient.class);
private static String INSTANCE_UUID;
+ private static List<KeyStringValuePair> SERVICE_PROPERTIES;
Review comment:
aha, thanks to your remind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services