You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Chris Custine (JIRA)" <ji...@apache.org> on 2009/05/01 08:42:38 UTC
[jira] Created: (SMXCOMP-518) Improve test coverage - ServiceMix ::
FTP
Improve test coverage - ServiceMix :: FTP
-----------------------------------------
Key: SMXCOMP-518
URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
Project: ServiceMix Components
Issue Type: Test
Components: servicemix-ftp
Affects Versions: servicemix-ftp-2009.01
Reporter: Chris Custine
http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMXCOMP-518) Improve test coverage - ServiceMix
:: FTP
Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52216#action_52216 ]
Greg Lucas commented on SMXCOMP-518:
------------------------------------
Thanks for looking at these Chris. I did indeed intend to remove those files. I also found SMXCOMP-556 running these tests and proposed a patch for that if you'd like to take a look.
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
> Assignee: Chris Custine
> Attachments: SMXCOMP-518.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SMXCOMP-518) Improve test coverage - ServiceMix
:: FTP
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine resolved SMXCOMP-518.
-----------------------------------
Resolution: Fixed
Fix Version/s: servicemix-ftp-2009.02
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
> Assignee: Chris Custine
> Fix For: servicemix-ftp-2009.02
>
> Attachments: SMXCOMP-518.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMXCOMP-518) Improve test coverage - ServiceMix
:: FTP
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52212#action_52212 ]
Chris Custine commented on SMXCOMP-518:
---------------------------------------
Hi Greg, just reviewing these patches and everything looks great but I have one question. The older PollDirectoryTest and SpringComponentTest appear redundant now and actually fail now that they are not excluded in the surefire config. Did you intend to remove those?
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
> Assignee: Chris Custine
> Attachments: SMXCOMP-518.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMXCOMP-518) Improve test coverage - ServiceMix
:: FTP
Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51476#action_51476 ]
Greg Lucas commented on SMXCOMP-518:
------------------------------------
I'd like to take a shot at improving the test coverage for this component.
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMXCOMP-518) Improve test coverage - ServiceMix ::
FTP
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Custine updated SMXCOMP-518:
----------------------------------
Assignee: Chris Custine
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
> Assignee: Chris Custine
> Attachments: SMXCOMP-518.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMXCOMP-518) Improve test coverage - ServiceMix
:: FTP
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52220#action_52220 ]
Chris Custine commented on SMXCOMP-518:
---------------------------------------
Thanks to Greg Lucas. Patches applied.
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
> Assignee: Chris Custine
> Fix For: servicemix-ftp-2009.02
>
> Attachments: SMXCOMP-518.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMXCOMP-518) Improve test coverage - ServiceMix ::
FTP
Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMXCOMP-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Lucas updated SMXCOMP-518:
-------------------------------
Attachment: SMXCOMP-518.patch
Added tests, coverage is about 72%.
> Improve test coverage - ServiceMix :: FTP
> -----------------------------------------
>
> Key: SMXCOMP-518
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-518
> Project: ServiceMix Components
> Issue Type: Test
> Components: servicemix-ftp
> Affects Versions: servicemix-ftp-2009.01
> Reporter: Chris Custine
> Attachments: SMXCOMP-518.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/98559
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.