You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/15 02:30:29 UTC

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #328: fix 305 by using a null array as param for zero param functions

Jimexist commented on a change in pull request #328:
URL: https://github.com/apache/arrow-datafusion/pull/328#discussion_r632883017



##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -1358,6 +1366,18 @@ impl fmt::Display for ScalarFunctionExpr {
     }
 }
 
+/// null columnar values are implemented as a null array in order to pass batch
+/// num_rows
+type NullColumnarValue = ColumnarValue;
+
+impl TryFrom<&RecordBatch> for NullColumnarValue {
+    type Error = DataFusionError;
+    fn try_from(batch: &RecordBatch) -> Result<Self> {

Review comment:
       updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org