[GitHub] williaster commented on issue #6473: [BigNumber] fix metric change

[GitBox <gi...@apache.org>]

williaster commented on issue #6473: [BigNumber] fix metric change
URL: https://github.com/apache/incubator-superset/pull/6473#issuecomment-444229643
 
 
   @mistercrunch we think this is non-ideal because it forces vis creators to know when to use `formData` vs `payload.formData` which is complicated and error-prone, and also duplicates the logic behind `renderTrigger` to some extent. 
   
   So instead we'd propose adding the following (in @conglei's PR)
   - do not trigger a chart update if the `run query / dismiss` overlay is shown (this will prevent the bug this PR is attempting to fix)
   - remove the dismiss option from the overlay, as this would provide a simple solution to the edge case bug that Conglei pointed out where a user 
     1) updates a non-renderTrigger control 
     2) dismisses overlay 
     3) updates a renderTrigger control
     4) chart updates, but doesn't actually have the update from 1)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org