[GitHub] [helix] mgao0 commented on a change in pull request #1995: Implement DefaultCloudEventCallbackImpl

[GitBox <gi...@apache.org>]

mgao0 commented on a change in pull request #1995:
URL: https://github.com/apache/helix/pull/1995#discussion_r835658206



##########
File path: helix-core/src/main/java/org/apache/helix/cloud/event/helix/DefaultCloudEventCallbackImpl.java
##########
@@ -19,22 +19,27 @@
  * under the License.
  */
 
+import java.util.List;
+
 import org.apache.helix.HelixManager;
-import sun.reflect.generics.reflectiveObjects.NotImplementedException;
+import org.apache.helix.constants.InstanceConstants;
+import org.apache.helix.util.InstanceValidationUtil;
 
 /**
  * A default callback implementation class to be used in {@link HelixCloudEventListener}
  */
 public class DefaultCloudEventCallbackImpl {
+  public static final String REASON = "CloudEvent";

Review comment:
       Reason added. Please review.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org