[GitHub] [maven-resolver] michael-o commented on a diff in pull request #212: Drop PartialFile use

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #212:
URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1010856434


##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -478,21 +454,16 @@ protected void runTask()
         {
             fileProcessor.mkdirs( file.getParentFile() );
 
-            PartialFile partFile = partialFileFactory.newInstance( file, this );
-            if ( partFile == null )
-            {
-                LOGGER.debug( "Concurrent download of {} just finished, skipping download", file );
-                return;
-            }
+            File tempFile =
+                    File.createTempFile( file.getName() + '-' + UUID.randomUUID().toString().replace( "-", "" ), ".tmp",

Review Comment:
   why this pain `.toString().replace( "-", "" )`? Use as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org