You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2020/07/13 15:00:47 UTC

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #238: OAK-9131 : introducing scanners for references to nt:frozenNode

stefan-egli commented on pull request #238:
URL: https://github.com/apache/jackrabbit-oak/pull/238#issuecomment-657612134


   @mreutegg thx for the review - I've done the changes in [this commit](https://github.com/apache/jackrabbit-oak/pull/238/commits/fb8b330c4f248078bb2dce62cfb19ae90a50030c)
   
   > In general, can those two commands run in read-only mode? This would make them safe to run on data that is in use. E.g. a production system.
   
   Yes, and with the suggested move of the test code to a test class this is now also more clear: only the test class uses the `-read-write=true` parameter - so even more reason to move test code to a test class indeed.
   > Could you please also update the README.md?
   
   Yes, will add next, thx for the pointer


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org