You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/17 04:59:05 UTC
[kudu-CR] build: tinker with gold linker detection
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14481
to review the following change.
Change subject: build: tinker with gold linker detection
......................................................................
build: tinker with gold linker detection
Our precommit builds have the "optional and buggy" gold, yet were dropping
tcmalloc despite not actually using gold. This patch adjusts the detection
to allow for gold to be used in such situations.
Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
---
M CMakeLists.txt
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/14481/1
--
To view, visit http://gerrit.cloudera.org:8080/14481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
Gerrit-Change-Number: 14481
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] build: tinker with gold linker detection
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14481 )
Change subject: build: tinker with gold linker detection
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
Gerrit-Change-Number: 14481
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] build: tinker with gold linker detection
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14481 )
Change subject: build: tinker with gold linker detection
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/14481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
Gerrit-Change-Number: 14481
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 09:01:13 +0000
Gerrit-HasComments: No
[kudu-CR] build: tinker with gold linker detection
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14481 )
Change subject: build: tinker with gold linker detection
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
Gerrit-Change-Number: 14481
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Oct 2019 16:22:55 +0000
Gerrit-HasComments: No
[kudu-CR] build: tinker with gold linker detection
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14481 )
Change subject: build: tinker with gold linker detection
......................................................................
build: tinker with gold linker detection
Our precommit builds have the "optional and buggy" gold, yet were dropping
tcmalloc despite not actually using gold. This patch adjusts the detection
to allow for gold to be used in such situations.
Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
Reviewed-on: http://gerrit.cloudera.org:8080/14481
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14481
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69fc0ed78731d7ce452e751bab414ae98284886a
Gerrit-Change-Number: 14481
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>