You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/05 21:29:06 UTC

[GitHub] [pinot] etolbakov commented on pull request #9884: WIP - feat: add compressed file support for ORCRecordReader

etolbakov commented on PR #9884:
URL: https://github.com/apache/pinot/pull/9884#issuecomment-1338196048

   hi @snleee,
   I've made some adjustments. Could you please take a look when you have time?
   
   While I was implementing the solution was a bit concerned about the code duplication, but not sure if extracting`unpackIfRequired` into, f.e. `RecordReaderUtils` would make the code clear.  Please let me know what do you think about it.
   Also regarding the`isGZippedFile`  utility method as far as I understood we would like to support only `gz` and not archive files in general, right?
   
   ---
   Regards, Eugene


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org