You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by JihongMA <gi...@git.apache.org> on 2017/01/07 20:18:15 UTC
[GitHub] incubator-carbondata pull request #505: [CARBONDATA-607] Cleanup ValueCompre...
GitHub user JihongMA opened a pull request:
https://github.com/apache/incubator-carbondata/pull/505
[CARBONDATA-607] Cleanup ValueCompressionHolder class and all sub-classes
1. Rewrite ValueCompressionHolder class as a base class for compressing or uncompressing numeric data for measurement column chunk.
2. Refactor all sub-classes under
org.apache.carbondata.core.datastorage.store.compression.decimal.*
org.apache.carbondata.core.datastorage.store.compression.nonDecimal.*
org.apache.carbondata.core.datastorage.store.compression.none.*
org.apache.carbondata.core.datastorage.store.compression.type.*
3. fix performance bug by avoiding creating unnecessary compress/uncompres value holder during compression or decompression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JihongMA/incubator-carbondata carbondata-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #505
----
commit 1241ada35d3463eee2c9850590792b72bca4c416
Author: Jihong Ma <ji...@jihongs-macbook-pro.local>
Date: 2016-12-13T00:31:12Z
Merge remote-tracking branch 'upstream/master'
commit 0bf1fb35c79f0fe12cc0e61a8b6c53b51085bdcc
Author: Jihong Ma <ji...@jihongs-macbook-pro.local>
Date: 2016-12-20T01:55:53Z
Merge remote-tracking branch 'upstream/master'
commit f5483b6a58f4cdeec91850bf2127fba009eb6654
Author: Jihong Ma <ji...@jihongs-macbook-pro.local>
Date: 2016-12-24T16:11:20Z
Merge remote-tracking branch 'upstream/master'
commit 1600f4dc3314a492aedc8e6950fc9cbc33f0a76f
Author: Jihong Ma <ji...@apache.org>
Date: 2017-01-03T22:09:39Z
Merge remote-tracking branch 'upstream/master'
commit 3bebe0a1f38258ebfe5ef5490fc1b95cb96e362f
Author: Jihong Ma <ji...@apache.org>
Date: 2017-01-05T18:41:39Z
Merge remote-tracking branch 'upstream/master'
commit 624efc1d9a4d5ff178a3958606b0155236dbea46
Author: Jihong Ma <ji...@apache.org>
Date: 2017-01-07T20:01:08Z
cleanup ValueCompressionHolder and sub-classes
commit 347c10e460ce2f9dffa11fde1c4e519ca08ce6d7
Author: Jihong Ma <ji...@apache.org>
Date: 2017-01-07T20:16:10Z
minor fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #505: [CARBONDATA-607] Cleanup ValueCompre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #505: [CARBONDATA-607] Cleanup ValueCompressionHo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/505
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/546/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #505: [CARBONDATA-607] Cleanup ValueCompressionHo...
Posted by JihongMA <gi...@git.apache.org>.
Github user JihongMA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/505
@ravipesala I looked at the code conflicted/introduced by the other PR, the new method introduced in the base & sub-classes are not proper abstraction again, I am going to cleanup those new code as part of rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #505: [CARBONDATA-607] Cleanup ValueCompressionHo...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/505
@JihongMA Please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #505: [CARBONDATA-607] Cleanup ValueCompressionHo...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/505
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #505: [CARBONDATA-607] Cleanup ValueCompressionHo...
Posted by JihongMA <gi...@git.apache.org>.
Github user JihongMA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/505
please review promptly! this is pretty tedious rebase and cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #505: [CARBONDATA-607] Cleanup ValueCompressionHo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/505
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/499/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---