You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ms...@apache.org on 2025/07/28 13:46:59 UTC
(superset) branch msyavuz/fix/pivot-cell-html created (now 7e6891da6e)
This is an automated email from the ASF dual-hosted git repository.
msyavuz pushed a change to branch msyavuz/fix/pivot-cell-html
in repository https://gitbox.apache.org/repos/asf/superset.git
at 7e6891da6e fix(PivotTable): Render html in cells if allowRenderHtml is true
This branch includes the following new commits:
new 7e6891da6e fix(PivotTable): Render html in cells if allowRenderHtml is true
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: fix(PivotTable): Render html in cells if allowRenderHtml is true
Posted by ms...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
msyavuz pushed a commit to branch msyavuz/fix/pivot-cell-html
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 7e6891da6ee87c1fe0dfc3a22bee24873d7a22b0
Author: Mehmet Salih Yavuz <sa...@proton.me>
AuthorDate: Mon Jul 28 16:42:10 2025 +0300
fix(PivotTable): Render html in cells if allowRenderHtml is true
---
.../src/react-pivottable/TableRenderers.jsx | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx b/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
index 06085a42ad..60ea1e68f6 100644
--- a/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
+++ b/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
@@ -34,6 +34,12 @@ const parseLabel = value => {
return String(value);
};
+function displayCell(value, allowRenderHtml) {
+ if (allowRenderHtml && typeof value === 'string') {
+ return safeHtmlSpan(value);
+ }
+ return parseLabel(value);
+}
function displayHeaderCell(
needToggle,
ArrowIcon,
@@ -742,7 +748,7 @@ export class TableRenderer extends Component {
onContextMenu={e => this.props.onContextMenu(e, colKey, rowKey)}
style={style}
>
- {agg.format(aggValue)}
+ {displayCell(agg.format(aggValue), allowRenderHtml)}
</td>
);
});
@@ -759,7 +765,7 @@ export class TableRenderer extends Component {
onClick={rowTotalCallbacks[flatRowKey]}
onContextMenu={e => this.props.onContextMenu(e, undefined, rowKey)}
>
- {agg.format(aggValue)}
+ {displayCell(agg.format(aggValue), allowRenderHtml)}
</td>
);
}
@@ -823,7 +829,7 @@ export class TableRenderer extends Component {
onContextMenu={e => this.props.onContextMenu(e, colKey, undefined)}
style={{ padding: '5px' }}
>
- {agg.format(aggValue)}
+ {displayCell(agg.format(aggValue), this.props.allowRenderHtml)}
</td>
);
});
@@ -840,7 +846,7 @@ export class TableRenderer extends Component {
onClick={grandTotalCallback}
onContextMenu={e => this.props.onContextMenu(e, undefined, undefined)}
>
- {agg.format(aggValue)}
+ {displayCell(agg.format(aggValue), this.props.allowRenderHtml)}
</td>
);
}