You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/05 21:22:47 UTC
Re: Review Request 45595: Implemented slave default docker config file
support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45595/
-----------------------------------------------------------
(Updated April 5, 2016, 12:22 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-5065
https://issues.apache.org/jira/browse/MESOS-5065
Repository: mesos
Description
-------
Implemented slave default docker config file support.
Diffs (updated)
-----
src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53
src/slave/containerizer/docker.cpp 6a8a705186b3a309329825a6b75ad038c2db4ac1
src/tests/mesos.hpp dc0e4dd6341f7d1931f3871991f6a3f20a477159
src/tests/mesos.cpp 543b2a7f3d1a4da28a5901fb238285cea6778c2b
Diff: https://reviews.apache.org/r/45595/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh
Tested with a private repo using ./mesos-execute
Thanks,
Gilbert Song
Re: Review Request 45595: Implemented slave default docker config file
support.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45595/#review127217
-----------------------------------------------------------
Ship it!
- Jie Yu
On April 5, 2016, 7:34 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45595/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 7:34 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-5065
> https://issues.apache.org/jira/browse/MESOS-5065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented slave default docker config file support.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53
> src/slave/containerizer/docker.cpp 6a8a705186b3a309329825a6b75ad038c2db4ac1
> src/tests/mesos.hpp dc0e4dd6341f7d1931f3871991f6a3f20a477159
> src/tests/mesos.cpp 543b2a7f3d1a4da28a5901fb238285cea6778c2b
>
> Diff: https://reviews.apache.org/r/45595/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh
>
> Tested with a private repo using ./mesos-execute
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 45595: Implemented slave default docker config file
support.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45595/
-----------------------------------------------------------
(Updated April 5, 2016, 12:34 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-5065
https://issues.apache.org/jira/browse/MESOS-5065
Repository: mesos
Description
-------
Implemented slave default docker config file support.
Diffs (updated)
-----
src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
src/docker/docker.cpp 4d35513cdd9c044d37d876a6db7dd9321ceaca53
src/slave/containerizer/docker.cpp 6a8a705186b3a309329825a6b75ad038c2db4ac1
src/tests/mesos.hpp dc0e4dd6341f7d1931f3871991f6a3f20a477159
src/tests/mesos.cpp 543b2a7f3d1a4da28a5901fb238285cea6778c2b
Diff: https://reviews.apache.org/r/45595/diff/
Testing
-------
make check
sudo ./bin/mesos-test.sh
Tested with a private repo using ./mesos-execute
Thanks,
Gilbert Song