[GitHub] [metron] merrimanr edited a comment on issue #1436: METRON-2149: Shaded jar classifier is not consistent

[GitBox <gi...@apache.org>]

merrimanr edited a comment on issue #1436: METRON-2149: Shaded jar classifier is not consistent
URL: https://github.com/apache/metron/pull/1436#issuecomment-522736603
 
 
   The latest commits implement the change I proposed above (option 2).  For clarity's sake, here it is again:
   
   > Deploy Stellar code in a separate jar and add it to classpath after the main uber jar, whatever that is (metron-data-management, metron-enrichment-storm, etc). This satisfies 3 because the separate Stellar jar can contain the relocated classes but other dependencies will not overwrite dependencies of the main uber jar (because it's listed after the main uber jar). 1 and 2 are not a concern when classifiers are used which is the case here. The main disadvantage I see is that there will be work adding this extra jar in the various scripts or startup options and we may have to reorganize some classes.
   
   I have finished some fairly exhaustive testing and will update the original PR description with that test plan next.  This approach was fairly straightforward with the exception of an integration test in `metron-data-management` (the `pom.xml` file contains a comment with an explanation).  I will also update the Changes Included section in the original PR description to include the changes needed for this approach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services