You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/06/01 07:28:07 UTC

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7041

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................

IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

I added the syntax and examples under ALTER TABLE, and also amended
the wording in the list of ALTER TABLE restrictions to reflect the
lifting of some restrictions.

I didn't have detailed discussion of ALTER TABLE in the impala_kudu.xml
page, so I didn't make any changes there.

Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
---
M docs/topics/impala_alter_table.xml
1 file changed, 24 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/7041/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................


Patch Set 1:

> did we also add ALTER TABLE ALTER COLUMN SET DEFAULT and such?

Didn't make it in the release, still in CR:
https://gerrit.cloudera.org/#/c/6955/

-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................


IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

I added the syntax and examples under ALTER TABLE, and also amended
the wording in the list of ALTER TABLE restrictions to reflect the
lifting of some restrictions.

I didn't have detailed discussion of ALTER TABLE in the impala_kudu.xml
page, so I didn't make any changes there.

Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Reviewed-on: http://gerrit.cloudera.org:8080/7041
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_alter_table.xml
1 file changed, 24 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................


Patch Set 1:

did we also add ALTER TABLE ALTER COLUMN SET DEFAULT and such?

-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu
......................................................................


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/122/

-- 
To view, visit http://gerrit.cloudera.org:8080/7041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f87155dcba860f6fd9259387fea52bbe439e028
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No