[jira] [Work logged] (BEAM-14011) AWS SDK2 S3FileSystem MultiPart Copy sets incorrect request parameters

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14011?focusedWorklogId=735387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735387 ]

ASF GitHub Bot logged work on BEAM-14011:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Mar/22 16:34
            Start Date: 02/Mar/22 16:34
    Worklog Time Spent: 10m 
      Work Description: spatel11 opened a new pull request #16987:
URL: https://github.com/apache/beam/pull/16987


   This PR fixes the AWS2 S3FileSystem multipart copy.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [x] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 735387)
    Remaining Estimate: 0h
            Time Spent: 10m

> AWS SDK2 S3FileSystem MultiPart Copy sets incorrect request parameters
> ----------------------------------------------------------------------
>
>                 Key: BEAM-14011
>                 URL: https://issues.apache.org/jira/browse/BEAM-14011
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-aws
>    Affects Versions: 2.29.0, 2.30.0, 2.31.0, 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0
>            Reporter: Stephen Patel
>            Assignee: Stephen Patel
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The following code locations use incorrect parameters:
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L518-L519] and [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L539-L540] specifies the sourcePath instead of the destinationPath.
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L541] specifies destinationPath.getBucket() instead of sourcePath.getBucket()
> [Here|https://github.com/apache/beam/blob/v2.36.0/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java#L556] specifies a constant part number of 1, instead of using the partNumber variable.
> Taken together, these issues cause multipart copies to fail due to:
> {noformat}
> software.amazon.awssdk.services.s3.model.NoSuchUploadException: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.
> {noformat}
> If the object references are fixes, the part number issue causes multipart copies to fail due to:
> {noformat}
> software.amazon.awssdk.services.s3.model.S3Exception: The list of parts was not in ascending order. Parts must be ordered by part number. 
> {noformat}
> Note: I checked the AWS SDK1 S3FileSystem and did not see the same issues.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)