[GitHub] [trafficserver] maskit commented on pull request #9482: Add interface for NetVC services

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on PR #9482:
URL: https://github.com/apache/trafficserver/pull/9482#issuecomment-1457402164

   `virtual void do_something()` is one of options. But in that way, NetVConnection would have a lot of that kind of functions. And I think it would be a mess eventually. I can imagine somebody will propose `do_something_detail_for_xyz` just for one of NetVCs without abstraction. Also, some of such functions would probably need some parameters. I guess it'd be difficult to abstract everything.
   
   `virtual bool is_feature_x_supprted()` for each mix-in may be better in that sense. But NetVC knows the name of x, and we have to modify NetVC base class whenever we add a new mix-in.
   
   `virtual bool has_support_for(enum_or_string feature_name)` is clean. It would not bring any detail to NetVC itself. If `get_service()` isn't acceptable, I can live with this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org