[GitHub] ascrutae commented on issue #1280: RuntimeContext error when in errorHandler

[GitBox <gi...@apache.org>]

ascrutae commented on issue #1280: RuntimeContext error when in errorHandler
URL: https://github.com/apache/incubator-skywalking/issues/1280#issuecomment-395597059
 
 
   I had found the root cause about this issue. here is my analysis:
   
   **REASON**:
   The Spring MVC framework `forward` the request when the controller method occur an exception,  It forward the request to `${server.error.path:${error.path:/error}}`, that URL  mapping to the  `BasicErrorController#error` method, The span that tomcat plugin generated finish  when the forward happened and it means the segment is finished. The Spring plugin depend on the `RuntimeContext` mechanism, the mechanism is active when the segment is active, or throws exception.
   
   **RESOLVE**:
   To Modify the tomcat interceptor make it contain the forward logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services