You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/08/06 16:39:06 UTC

[GitHub] [samza] cameronlee314 commented on a change in pull request #1126: Adding two additional params to DiagnosticsStreamMessage

cameronlee314 commented on a change in pull request #1126: Adding two additional params to DiagnosticsStreamMessage
URL: https://github.com/apache/samza/pull/1126#discussion_r311161809
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsStreamMessage.java
 ##########
 @@ -185,6 +203,14 @@ public Integer getNumStoresWithChangelog() {
         CONTAINER_NUM_STORES_WITH_CHANGELOG_METRIC_NAME);
   }
 
+  public Integer getContainerThreadPoolSize() {
+    return (Integer) getFromMetricsMessage(GROUP_NAME_FOR_DIAGNOSTICS_MANAGER, CONTAINER_THREAD_POOL_SIZE_METRIC_NAME);
+  }
+
+  public Long getMaxHeapSize() {
 
 Review comment:
   Minor: can you keep the same ordering for methods? So could you move this one above `getContainerThreadPoolSize`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services