You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/31 20:31:51 UTC

[GitHub] [maven-javadoc-plugin] alzimmermsft opened a new pull request, #159: Log javadoc warnings and errors to file

alzimmermsft opened a new pull request, #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   Adds a new `@errors` file to the output directory, similar to the `@options`, `@packages`, `@argfile`, and `@files`, that contains the warnings and errors returned by the Javadoc process and won't be contained in a Javadoc JAR. This allows for external processes to capture warnings and errors produced during Javadoc generation without the need for complex logging processes and ensures that the Javadoc warnings and errors aren't interleaved with other data if the logger is handling requests from multiple threads.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-722] Log javadoc warnings and errors to file [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1830747943

   So I reviewed it again and still consider is as flawed. `@files` are pure input files to the Javadoc process, they have nothing in common with the output of the process. I still consider `errorFile` as the param to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-722] Log javadoc warnings and errors to file [maven-javadoc-plugin]

Posted by "alzimmermsft (via GitHub)" <gi...@apache.org>.
alzimmermsft commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1827905944

   > @alzimmermsft Can you rebase, I will take another look at it. I have now a better understanding of this plugin. Ideally, can you also create an IT where such an output is depicted as well?
   
   Gladly, I will rebase this change soon and will add an integration test when I do that.
   
   Since it's been a while, do you still want `@errors` replaced with using `outputFile` to completely redirect error output? Similar to what is seen with plugins like Maven Dependency where `outputFile` completely redirects the output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961384498


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -183,28 +183,34 @@
 
     /**
      * The <code>options</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String OPTIONS_FILE_NAME = "options";
 
     /**
      * The <code>packages</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String PACKAGES_FILE_NAME = "packages";
 
     /**
      * The <code>argfile</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String ARGFILE_FILE_NAME = "argfile";
 
     /**
      * The <code>files</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String FILES_FILE_NAME = "files";
 
+    /**
+     * The <code>errors</code> file name in the output directory when calling:
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
+     */
+    protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   This does not make sense to me. Those files are passed to `javadoc(1)`. `errors` isn't passed. It is not related to the set of files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1277886474

   Hey @michael-o just following up on this 😃 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1280817033

   > So, while I partially understand this request, I consider it ill-designed. Treating the stdout/stderr as `@argfiles` or Javadoc produce feels wrong. This is just yet another convenience output just like in other plugins to write to a file.
   > 
   > Your request is similar to https://maven.apache.org/plugins/maven-dependency-plugin/list-mojo.html#outputFile or what other plugins do.
   
   Thanks for the feedback, I can get this changed to more closely follow the design used by `maven-dependency-plugin` if you see that as the best direction forward. Using `outputFile` to redirect the output instead of `@errors`, and changing outputing to file from being an additional output target to the only output target as right now `@errors` is an additional output in comparison to `outputFile` which is a redirection of output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964153349


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine, File javadocOutputDirector
         }
     }
 
+    /**
+     * Write a files containing the javadoc errors and warnings.
+     *
+     * @param errorsAndWarnings      the javadoc errors and warnings as string, not null.
+     * @param javadocOutputDirectory the output dir, not null.
+     * @since 3.4.2-SNAPSHOT
+     */
+    private void writeErrorFile( String errorsAndWarnings, File javadocOutputDirectory )
+    {
+        File commandLineFile = new File( javadocOutputDirectory, ERRORS_FILE_NAME );
+        commandLineFile.getParentFile().mkdirs();
+
+        try
+        {
+            FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /* platform encoding */, errorsAndWarnings );
+
+            if ( !SystemUtils.IS_OS_WINDOWS )
+            {
+                Runtime.getRuntime().exec( new String[]{ "chmod", "a+x", commandLineFile.getAbsolutePath() } );

Review Comment:
   Good point, I was following this pattern found elsewhere in the file:
   
   https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L6925
   
   But after taking a second look at it it's meant to be an executable file. I'll remove this entire if block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964140570


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine, File javadocOutputDirector
         }
     }
 
+    /**
+     * Write a files containing the javadoc errors and warnings.
+     *
+     * @param errorsAndWarnings      the javadoc errors and warnings as string, not null.
+     * @param javadocOutputDirectory the output dir, not null.
+     * @since 3.4.2-SNAPSHOT
+     */
+    private void writeErrorFile( String errorsAndWarnings, File javadocOutputDirectory )
+    {
+        File commandLineFile = new File( javadocOutputDirectory, ERRORS_FILE_NAME );
+        commandLineFile.getParentFile().mkdirs();
+
+        try
+        {
+            FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /* platform encoding */, errorsAndWarnings );
+
+            if ( !SystemUtils.IS_OS_WINDOWS )
+            {
+                Runtime.getRuntime().exec( new String[]{ "chmod", "a+x", commandLineFile.getAbsolutePath() } );

Review Comment:
   Why is this necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1252612003

   @michael-o just checking in again to see if there is anything else that is needed for this change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] michael-o commented on pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1252619897

   I won't review this before October 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1241222416

   Hi @michael-o, is there anything I need to update in this PR? I'm more than happy to make those changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961578775


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -183,28 +183,34 @@
 
     /**
      * The <code>options</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String OPTIONS_FILE_NAME = "options";
 
     /**
      * The <code>packages</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String PACKAGES_FILE_NAME = "packages";
 
     /**
      * The <code>argfile</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String ARGFILE_FILE_NAME = "argfile";
 
     /**
      * The <code>files</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String FILES_FILE_NAME = "files";
 
+    /**
+     * The <code>errors</code> file name in the output directory when calling:
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
+     */
+    protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   Got it, thanks! I went ahead and updated the Javadocs on the files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961560087


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -183,28 +183,34 @@
 
     /**
      * The <code>options</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String OPTIONS_FILE_NAME = "options";
 
     /**
      * The <code>packages</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String PACKAGES_FILE_NAME = "packages";
 
     /**
      * The <code>argfile</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String ARGFILE_FILE_NAME = "argfile";
 
     /**
      * The <code>files</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String FILES_FILE_NAME = "files";
 
+    /**
+     * The <code>errors</code> file name in the output directory when calling:
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
+     */
+    protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   Just to clarify, is it the Javadoc for the constant that makes no sense or the design pattern in general? Asking to know what to change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964177173


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine, File javadocOutputDirector
         }
     }
 
+    /**
+     * Write a files containing the javadoc errors and warnings.
+     *
+     * @param errorsAndWarnings      the javadoc errors and warnings as string, not null.
+     * @param javadocOutputDirectory the output dir, not null.
+     * @since 3.4.2-SNAPSHOT
+     */
+    private void writeErrorFile( String errorsAndWarnings, File javadocOutputDirectory )
+    {
+        File commandLineFile = new File( javadocOutputDirectory, ERRORS_FILE_NAME );
+        commandLineFile.getParentFile().mkdirs();
+
+        try
+        {
+            FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /* platform encoding */, errorsAndWarnings );
+
+            if ( !SystemUtils.IS_OS_WINDOWS )
+            {
+                Runtime.getRuntime().exec( new String[]{ "chmod", "a+x", commandLineFile.getAbsolutePath() } );

Review Comment:
   Yeah, now this simply just does file writing with no modifications to the permissions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964160516


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine, File javadocOutputDirector
         }
     }
 
+    /**
+     * Write a files containing the javadoc errors and warnings.
+     *
+     * @param errorsAndWarnings      the javadoc errors and warnings as string, not null.
+     * @param javadocOutputDirectory the output dir, not null.
+     * @since 3.4.2-SNAPSHOT
+     */
+    private void writeErrorFile( String errorsAndWarnings, File javadocOutputDirectory )
+    {
+        File commandLineFile = new File( javadocOutputDirectory, ERRORS_FILE_NAME );
+        commandLineFile.getParentFile().mkdirs();
+
+        try
+        {
+            FileUtils.fileWrite( commandLineFile.getAbsolutePath(), null /* platform encoding */, errorsAndWarnings );
+
+            if ( !SystemUtils.IS_OS_WINDOWS )
+            {
+                Runtime.getRuntime().exec( new String[]{ "chmod", "a+x", commandLineFile.getAbsolutePath() } );

Review Comment:
   The file referenced is a script, totally unrelated to this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] alzimmermsft commented on pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
alzimmermsft commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1252632868

   > I won't review this before October
   
   Got it, thanks for the update. I'll check back in a couple weeks and make sure there are no merge conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961563431


##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -183,28 +183,34 @@
 
     /**
      * The <code>options</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String OPTIONS_FILE_NAME = "options";
 
     /**
      * The <code>packages</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String PACKAGES_FILE_NAME = "packages";
 
     /**
      * The <code>argfile</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String ARGFILE_FILE_NAME = "argfile";
 
     /**
      * The <code>files</code> file name in the output directory when calling:
-     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files</code>
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
      */
     protected static final String FILES_FILE_NAME = "files";
 
+    /**
+     * The <code>errors</code> file name in the output directory when calling:
+     * <code>javadoc.exe(or .sh) &#x40;options &#x40;packages | &#x40;argfile | &#x40;files | &#x40;errors</code>
+     */
+    protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   Those files are designed to be passed as `@arg` files. This new file, does not. It does not make logically sense to apply the same documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-722] Log javadoc warnings and errors to file [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1826889625

   @alzimmermsft Can you rebase, I will take another look at it. I have now a better understanding of this plugin. Ideally, can you also create an IT where such an output is depicted as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-722] Log javadoc warnings and errors to file [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #159:
URL: https://github.com/apache/maven-javadoc-plugin/pull/159#issuecomment-1830063175

   I will get back to you as soon as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org