[GitHub] [spark] tharradine commented on pull request #28946: [SPARK-32123][PYSPARK] Setting `spark.sql.session.timeZone` only partially respected

[GitBox <gi...@apache.org>]

tharradine commented on pull request #28946:
URL: https://github.com/apache/spark/pull/28946#issuecomment-651455471


   This isn't exactly the SPARK-32123 fix I was expecting, I was expecting the behaviour mentioned in the [docs](https://spark.apache.org/docs/2.3.0/sql-programming-guide.html#timestamp-with-time-zone-semantics) to be adhered to, specifically:
   
   > When timestamp data is exported or displayed in Spark, the session time zone is used to localize the timestamp values.
   
   Is it not preferable to perform this localization whilst converting from/to internal timestamp datatypes, and preserve the documented behaviour?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org