You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Shane Witbeck (JIRA)" <ji...@apache.org> on 2010/07/08 17:44:49 UTC
[jira] Created: (BUILDR-468) test:failed does not respect
test.exclude
test:failed does not respect test.exclude
-----------------------------------------
Key: BUILDR-468
URL: https://issues.apache.org/jira/browse/BUILDR-468
Project: Buildr
Issue Type: Bug
Components: Test frameworks
Affects Versions: 1.4.1
Environment: JRuby 1.5.1, Windows XP
Reporter: Shane Witbeck
I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-468) test:failed does not respect
test.exclude
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887132#action_12887132 ]
Antoine Toulme commented on BUILDR-468:
---------------------------------------
OK I can reproduce. I have a fix coming up.
> test:failed does not respect test.exclude
> -----------------------------------------
>
> Key: BUILDR-468
> URL: https://issues.apache.org/jira/browse/BUILDR-468
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Affects Versions: 1.4.1
> Environment: JRuby 1.5.1, Windows XP
> Reporter: Shane Witbeck
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-468) test:failed does not respect
test.exclude
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887074#action_12887074 ]
Antoine Toulme commented on BUILDR-468:
---------------------------------------
Shane, I don't reproduce the problem ? I committed a spec with this commit:
10:37:00~/w/buildr>svn ci spec/core/test_spec.rb -m "spec for BUILDR-468"
Sending spec/core/test_spec.rb
Transmitting file data .
Committed revision 962892.
10:36:54~/w/buildr>di spec/core/test_spec.rb
Index: spec/core/test_spec.rb
===================================================================
--- spec/core/test_spec.rb (revision 961875)
+++ spec/core/test_spec.rb (working copy)
@@ -945,6 +945,20 @@
project('foo').test.tests.should include('FailingTest')
project('foo').test.tests.should_not include('PassingTest')
end
+
+ it 'should run failed tests, respecting excluded tests' do
+ define 'foo' do
+ test.using(:junit).exclude('ExcludedTest')
+ test.instance_eval do
+ @framework.stub!(:tests).and_return(['FailingTest', 'ExcludedTest'])
+ @framework.stub!(:run).and_return([])
+ end
+ end
+ write project('foo').path_to(:target, "junit-failed"), "FailingTest\nExcludedTest"
+ task('test:failed').invoke rescue nil
+ project('foo').test.tests.should include('FailingTest')
+ project('foo').test.tests.should_not include('ExcludedTest')
+ end
end
> test:failed does not respect test.exclude
> -----------------------------------------
>
> Key: BUILDR-468
> URL: https://issues.apache.org/jira/browse/BUILDR-468
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Affects Versions: 1.4.1
> Environment: JRuby 1.5.1, Windows XP
> Reporter: Shane Witbeck
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-468) test:failed does not respect
test.exclude
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme reassigned BUILDR-468:
-------------------------------------
Assignee: Antoine Toulme
> test:failed does not respect test.exclude
> -----------------------------------------
>
> Key: BUILDR-468
> URL: https://issues.apache.org/jira/browse/BUILDR-468
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Affects Versions: 1.4.1
> Environment: JRuby 1.5.1, Windows XP
> Reporter: Shane Witbeck
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-468) test:failed does not respect
test.exclude
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-468:
----------------------------------
Fix Version/s: 1.4.2
> test:failed does not respect test.exclude
> -----------------------------------------
>
> Key: BUILDR-468
> URL: https://issues.apache.org/jira/browse/BUILDR-468
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Affects Versions: 1.4.1
> Environment: JRuby 1.5.1, Windows XP
> Reporter: Shane Witbeck
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-468) test:failed does not respect
test.exclude
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887880#action_12887880 ]
Hudson commented on BUILDR-468:
-------------------------------
Integrated in Buildr-ci-build #60 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/60/])
fix for BUILDR-468: test:failed does not respect test.exclude
spec for BUILDR-468
> test:failed does not respect test.exclude
> -----------------------------------------
>
> Key: BUILDR-468
> URL: https://issues.apache.org/jira/browse/BUILDR-468
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Affects Versions: 1.4.1
> Environment: JRuby 1.5.1, Windows XP
> Reporter: Shane Witbeck
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-468) test:failed does not respect
test.exclude
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-468.
-----------------------------------
Resolution: Fixed
Fixed!
18:32:50~/w/buildr>svn ci lib/buildr/core/test.rb spec/core/test_spec.rb CHANGELOG -m "fix for BUILDR-468: test:failed does not respect test.exclude"
Sending CHANGELOG
Sending lib/buildr/core/test.rb
Sending spec/core/test_spec.rb
Transmitting file data ...
Committed revision 962970.
> test:failed does not respect test.exclude
> -----------------------------------------
>
> Key: BUILDR-468
> URL: https://issues.apache.org/jira/browse/BUILDR-468
> Project: Buildr
> Issue Type: Bug
> Components: Test frameworks
> Affects Versions: 1.4.1
> Environment: JRuby 1.5.1, Windows XP
> Reporter: Shane Witbeck
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> I ran test:failed which resulted in an excluded test in a dependent project to run.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.