[GitHub] [airflow] potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303227624
 
 

 ##########
 File path: airflow/_vendor/nvd3/NVD3Chart.py
 ##########
 @@ -36,7 +36,7 @@ def stab(tab=1):
     return ' ' * 4 * tab
 
 
-class NVD3Chart(object):
+class NVD3Chart:
 
 Review comment:
   I think we discussed it before already re: vendor updates. And since we already modified those projects, I see no reason why we should not introduce those Py3 changes here. 
   
   I think the whole reason of _vendor is to keep sources of external libraries that we could not use directly as dependency but we had to modify the sources. So we already know it's legal to modify the sources and we've already done that. 
   
   Those consistency modifications are not technically needed but adding Py3 consistency everywhere is a value on its own (for example it might make some tools work better - like black in the future maybe - if all our code is PY3 only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services