You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2019/02/13 16:08:43 UTC

Formal code reviews and PRs

Folks

Since HttpComponents migration to GitBox I have been committing all my
code changes to a feature branch and leaving them sit there for a day
or two prior to merging them to a development branch (master or stable
version branches).

If there is anyone interested in doing formal code reviews of my
changes please do let me know. I'll start raising PRs at GitHub for all
my feature branches.

Cheers

Oleg 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Re: Re: Formal code reviews and PRs

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, 2019-02-14 at 16:27 +0100, Michael Osipov wrote:
> > Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr
> > Von: "Oleg Kalnichevski" <ol...@apache.org>
> > An: "HttpComponents Project" <de...@hc.apache.org>
> > Betreff: Re: Re: Formal code reviews and PRs
> > 
> > On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote:
> > > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > > > > That sounds nice.
> > > > > 
> > > > > Can we agree to add trivial changes to master directly, for
> > > > > example,
> > > > > if I
> > > > > want to Javadoc a previously undocumented method?
> > > > > 
> > > > 
> > > > I disagree rather strongly, especially if we want to keep
> > > > master
> > > > branch
> > > > protected. Even trivial changes can break the build and
> > > > introduce
> > > > style
> > > > violations. 
> > > 
> > > That's fair. That would mean we have a multibranch pipeline setup
> > > on
> > > Jenkins.
> > > Do we? If it doesn't fail there, it should be good for a PR or
> > > merge.
> > > totally
> > > fine by me.
> > > 
> > 
> > We have got Travis-CI right now and the multibranch pipeline setup
> > on
> > ASF Jenkins is something I would like to look into.
> 
> You shall be able to shamelessly steal the config from Maven TLP and
> modify it.
> 

Shameless stealing is what I intend to do when it comes to good
practices in CI.

Oleg

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Re: Re: Formal code reviews and PRs

Posted by Michael Osipov <19...@gmx.net>.
> Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr
> Von: "Oleg Kalnichevski" <ol...@apache.org>
> An: "HttpComponents Project" <de...@hc.apache.org>
> Betreff: Re: Re: Formal code reviews and PRs
>
> On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote:
> > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > > > That sounds nice.
> > > > 
> > > > Can we agree to add trivial changes to master directly, for
> > > > example,
> > > > if I
> > > > want to Javadoc a previously undocumented method?
> > > > 
> > > 
> > > I disagree rather strongly, especially if we want to keep master
> > > branch
> > > protected. Even trivial changes can break the build and introduce
> > > style
> > > violations. 
> > 
> > That's fair. That would mean we have a multibranch pipeline setup on
> > Jenkins.
> > Do we? If it doesn't fail there, it should be good for a PR or merge.
> > totally
> > fine by me.
> > 
> 
> We have got Travis-CI right now and the multibranch pipeline setup on
> ASF Jenkins is something I would like to look into.

You shall be able to shamelessly steal the config from Maven TLP and modify it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Re: Formal code reviews and PRs

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote:
> > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > > That sounds nice.
> > > 
> > > Can we agree to add trivial changes to master directly, for
> > > example,
> > > if I
> > > want to Javadoc a previously undocumented method?
> > > 
> > 
> > I disagree rather strongly, especially if we want to keep master
> > branch
> > protected. Even trivial changes can break the build and introduce
> > style
> > violations. 
> 
> That's fair. That would mean we have a multibranch pipeline setup on
> Jenkins.
> Do we? If it doesn't fail there, it should be good for a PR or merge.
> totally
> fine by me.
> 

We have got Travis-CI right now and the multibranch pipeline setup on
ASF Jenkins is something I would like to look into.

Oleg

> > > Gary
> > > 
> > > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski <
> > > olegk@apache.org>
> > > wrote:
> > > 
> > > > Folks
> > > > 
> > > > Since HttpComponents migration to GitBox I have been committing
> > > > all
> > > > my
> > > > code changes to a feature branch and leaving them sit there for
> > > > a
> > > > day
> > > > or two prior to merging them to a development branch (master or
> > > > stable
> > > > version branches).
> > > > 
> > > > If there is anyone interested in doing formal code reviews of
> > > > my
> > > > changes please do let me know. I'll start raising PRs at GitHub
> > > > for
> > > > all
> > > > my feature branches.
> > > > 
> > > > Cheers
> > > > 
> > > > Oleg
> > > > 
> > > > 
> > > > -------------------------------------------------------------
> > > > ----
> > > > ----
> > > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > > For additional commands, e-mail: dev-help@hc.apache.org
> > > > 
> > > > 
> > 
> > 
> > -----------------------------------------------------------------
> > ----
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> > 
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Re: Formal code reviews and PRs

Posted by Michael Osipov <19...@gmx.net>.
> On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > That sounds nice.
> > 
> > Can we agree to add trivial changes to master directly, for example,
> > if I
> > want to Javadoc a previously undocumented method?
> > 
> 
> I disagree rather strongly, especially if we want to keep master branch
> protected. Even trivial changes can break the build and introduce style
> violations. 

That's fair. That would mean we have a multibranch pipeline setup on Jenkins.
Do we? If it doesn't fail there, it should be good for a PR or merge. totally
fine by me.

> > Gary
> > 
> > On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski <ol...@apache.org>
> > wrote:
> > 
> > > Folks
> > > 
> > > Since HttpComponents migration to GitBox I have been committing all
> > > my
> > > code changes to a feature branch and leaving them sit there for a
> > > day
> > > or two prior to merging them to a development branch (master or
> > > stable
> > > version branches).
> > > 
> > > If there is anyone interested in doing formal code reviews of my
> > > changes please do let me know. I'll start raising PRs at GitHub for
> > > all
> > > my feature branches.
> > > 
> > > Cheers
> > > 
> > > Oleg
> > > 
> > > 
> > > -----------------------------------------------------------------
> > > ----
> > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > For additional commands, e-mail: dev-help@hc.apache.org
> > > 
> > > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Formal code reviews and PRs

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> That sounds nice.
> 
> Can we agree to add trivial changes to master directly, for example,
> if I
> want to Javadoc a previously undocumented method?
> 

I disagree rather strongly, especially if we want to keep master branch
protected. Even trivial changes can break the build and introduce style
violations. 

Oleg

> Gary
> 
> On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski <ol...@apache.org>
> wrote:
> 
> > Folks
> > 
> > Since HttpComponents migration to GitBox I have been committing all
> > my
> > code changes to a feature branch and leaving them sit there for a
> > day
> > or two prior to merging them to a development branch (master or
> > stable
> > version branches).
> > 
> > If there is anyone interested in doing formal code reviews of my
> > changes please do let me know. I'll start raising PRs at GitHub for
> > all
> > my feature branches.
> > 
> > Cheers
> > 
> > Oleg
> > 
> > 
> > -----------------------------------------------------------------
> > ----
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> > 
> > 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Re: Formal code reviews and PRs

Posted by Michael Osipov <19...@gmx.net>.
Absolutely!

> Gesendet: Donnerstag, 14. Februar 2019 um 15:14 Uhr
> Von: "Gary Gregory" <ga...@gmail.com>
> An: "HttpComponents Project" <de...@hc.apache.org>
> Betreff: Re: Formal code reviews and PRs
>
> That sounds nice.
> 
> Can we agree to add trivial changes to master directly, for example, if I
> want to Javadoc a previously undocumented method?
> 
> Gary
> 
> On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> 
> > Folks
> >
> > Since HttpComponents migration to GitBox I have been committing all my
> > code changes to a feature branch and leaving them sit there for a day
> > or two prior to merging them to a development branch (master or stable
> > version branches).
> >
> > If there is anyone interested in doing formal code reviews of my
> > changes please do let me know. I'll start raising PRs at GitHub for all
> > my feature branches.
> >
> > Cheers
> >
> > Oleg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

Re: Formal code reviews and PRs

Posted by Gary Gregory <ga...@gmail.com>.
That sounds nice.

Can we agree to add trivial changes to master directly, for example, if I
want to Javadoc a previously undocumented method?

Gary

On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski <ol...@apache.org> wrote:

> Folks
>
> Since HttpComponents migration to GitBox I have been committing all my
> code changes to a feature branch and leaving them sit there for a day
> or two prior to merging them to a development branch (master or stable
> version branches).
>
> If there is anyone interested in doing formal code reviews of my
> changes please do let me know. I'll start raising PRs at GitHub for all
> my feature branches.
>
> Cheers
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>

Re: Formal code reviews and PRs

Posted by Michael Osipov <mi...@apache.org>.
Am 2019-02-13 um 17:08 schrieb Oleg Kalnichevski:
> Folks
> 
> Since HttpComponents migration to GitBox I have been committing all my
> code changes to a feature branch and leaving them sit there for a day
> or two prior to merging them to a development branch (master or stable
> version branches).
> 
> If there is anyone interested in doing formal code reviews of my
> changes please do let me know. I'll start raising PRs at GitHub for all
> my feature branches.

I think this is a good idea. We are doing this with Maven also to gain 
more attraction and thus more reviewers. You should leave people at 
least three days to review. A day is just too short.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org