[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1678: Fix bug while merging `RecordBatch`, Add `SortPreservingMerge` fuzz tester

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1678:
URL: https://github.com/apache/arrow-datafusion/pull/1678#discussion_r792787450



##########
File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs
##########
@@ -410,40 +410,53 @@ impl SortPreservingMergeStream {
             // Cursor is not finished - don't need a new RecordBatch yet
             return Poll::Ready(Ok(()));
         }
-        let mut streams = self.streams.streams.lock().unwrap();
+        let mut empty_batch = false;

Review comment:
       The changes to this file are easier to see if you use a whitespace blind diff:
   https://github.com/apache/arrow-datafusion/pull/1678/files?w=1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org