You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/08/12 13:47:56 UTC
[GitHub] [systemds] OlgaOvcharenko opened a new pull request #1363: Federated rblk instruction
OlgaOvcharenko opened a new pull request #1363:
URL: https://github.com/apache/systemds/pull/1363
This PR adds federated reblock instruction and also extends FEDInstructionUtils.checkAndReplaceSP.
Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1363: [SYSTEMDS-3093] Check and replace SP instructions with federated instructions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1363:
URL: https://github.com/apache/systemds/pull/1363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1363: [SYSTEMDS-3093] Check and replace SP instructions with federated instructions
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1363:
URL: https://github.com/apache/systemds/pull/1363#issuecomment-922377164
LGTM - thanks for this major extension @OlgaOvcharenko. During the merge, I fixed the merge conflicts (in the future please rebase if possible), fixed the warnings and a few minor issues. As a next step, we should think about consolidating the now replicated federated matrix multiplication (in fed mapmm). Maybe we get away with dedicated instruction string handling and otherwise can channel everything through a single matrix multiplication (because there are of course many more spark matrix multiplications such as cpmm and rmm).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org