You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/11/13 17:11:12 UTC
[GitHub] [helix] alirezazamani commented on issue #583: Fix the context
creation without config
alirezazamani commented on issue #583: Fix the context creation without config
URL: https://github.com/apache/helix/pull/583#issuecomment-553499168
> Looks good, but in your tests I see a lot of duplicate code. We'll perhaps let this one slide, but if you ever need to write a similar test, consider refactoring so that we aren't copying and pasting the boilerplate code over and over.
Thanks Hunter. Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org