You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/06 23:56:30 UTC

[GitHub] [spark] dilipbiswal opened a new pull request #23995: [SQL][MINOR][TEST] Include usage example for generating output for single test in SQLQueryTestSuite

dilipbiswal opened a new pull request #23995: [SQL][MINOR][TEST] Include usage example for generating output for single test in SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/23995
 
 
   ## What changes were proposed in this pull request?
   This is a very minor pr to include the usage example to generate output for single test in SQLQueryTestSuite. I tried to deduce it from the existing example and ran into a scenario 
   where sbt is simply looping to run the same test over and over again. Here is the example
   of running a single test.
   
   ```
   build/sbt "~sql/test-only *SQLQueryTestSuite -- -z inline-table.sql"
   ```
   I tried to generate the output for a single test by prepending `SPARK_GENERATE_GOLDEN_FILES=1` like following
   ```
   SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "~sql/test-only *SQLQueryTestSuite -- -z describe.sql"
   ```
   In this case i found that sbt is looping trying to run describe.sql over and over again as we are running the test in on continuous mode (because of `~` prefix ) where it detects a change in 
   the generated result file which in turn triggers a build and test. I have included an example where
   we don't run it in continuous when generating the output. Hopefully it saves other developers some time.
   ## How was this patch tested?
   Verified manually in my dev setup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org