[GitHub] [incubator-druid] leventov opened a new pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

[GitBox <gi...@apache.org>]

leventov opened a new pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality
URL: https://github.com/apache/incubator-druid/pull/7185
 
 
   This patch makes Coordinator avoid at least 6 places where collections containing all segments in the cluster are materialized (or a group of collections, that combined contain all segments in the cluster).
   
   This patch includes #7073. #7073 needs to be merged first to retain @samarthjain's authorship.
   
   Additionally, this patch prohibits the following patterns in code:
   ```java
   c.addAll(Collections.unmodifiable{Set, List, ...}(c2));
   c.addAll(Immutable{Set, List}.copyOf(c2));
   m.putAll(Collections.unmodifiableMap(m2));
   m.putAll(ImmutableMap.copyOf(m2));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org