You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/06 15:52:38 UTC

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #170: Apache ShenYu (incubating) plugin support grpc,sofarpc,motan

wu-sheng commented on code in PR #170:
URL: https://github.com/apache/skywalking-java/pull/170#discussion_r866960221


##########
CHANGES.md:
##########
@@ -14,6 +14,7 @@ Release Notes.
 * Change the dateformat of logs to `yyyy-MM-dd HH:mm:ss.SSS`(was `yyyy-MM-dd HH:mm:ss:SSS`).
 * Fix NPE in elasticsearch plugin.
 * Grpc plugin support trace client async generic call(without grpc stubs), support Method type: `UNARY`、`SERVER_STREAMING`.
+* Enhance Apache ShenYu (incubating) plugin: support trace `grpc`,`sofarpc`,`motan`,`tars` rpc proxy.

Review Comment:
   tars? I am concerned about this, we don't have tars plugin for the service's RPC. This new feature seems a little misguided.
   
   Also, supported-list.md should be updated too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org