You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/06 13:07:46 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Jimexist opened a new pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764
# Which issue does this PR close?
- part of #1750
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764#discussion_r801646987
##########
File path: datafusion-expr/src/lib.rs
##########
@@ -16,12 +16,14 @@
// under the License.
mod aggregate_function;
Review comment:
so that each trait module can be migrated separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764#discussion_r801643132
##########
File path: datafusion-expr/src/built_in_function.rs
##########
@@ -0,0 +1,330 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
is the plan to move the built in aggregate functions here too?
##########
File path: datafusion-expr/src/lib.rs
##########
@@ -16,12 +16,14 @@
// under the License.
mod aggregate_function;
Review comment:
I also like how this reorganization is making the structure of `Expr` easier to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764#discussion_r801645844
##########
File path: datafusion-expr/src/built_in_function.rs
##########
@@ -0,0 +1,330 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
i think it's in the `aggregate_function` module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764#discussion_r801851363
##########
File path: datafusion-expr/src/lib.rs
##########
@@ -16,12 +16,14 @@
// under the License.
mod aggregate_function;
Review comment:
> is also trying to tear up the cumbersome/bloated expr by traits.
🏅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764#discussion_r801646738
##########
File path: datafusion-expr/src/lib.rs
##########
@@ -16,12 +16,14 @@
// under the License.
mod aggregate_function;
Review comment:
these:
- #1774
- #1784
is also trying to tear up the cumbersome/bloated expr by traits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist merged pull request #1764: [split/7] move built-in scalar function to datafusion-expr
Posted by GitBox <gi...@apache.org>.
Jimexist merged pull request #1764:
URL: https://github.com/apache/arrow-datafusion/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org