You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jagadish Venkatraman <ja...@gmail.com> on 2016/09/12 21:18:08 UTC
Review Request 51824: SAMZA-1016 Fix support for 'joint compilation'
of scala and java sources
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51824/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
The Samza gradle settings are not setup correctly for joint compilation of Java and Scala. When javac runs before scalac, the .java files that import scala classes will fail compilation. This is because scalac has not run (and hence, has not compiled the imported scala sources to class files). The reverse problem occurs when scalac is run before javac - ie. the .scala files that import java classes will fail compilation.
"Joint compilation" refers to compiling scala and java as a single compilation unit. This will disable the `java` plugin and will run the `scala` plugin to joint compile both java and scala sources.
Diffs
-----
build.gradle 004c81e9173c22dee3e282aad2a58a34a3e46fe2
checkstyle/checkstyle.xml 770b5e7f7a091198bbf53b3908600f9ac0caa4c7
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
samza-core/src/test/java/org/apache/samza/container/TestLocalityManager.java 9661885c1278c0d1cf53aae61f502ae719adfd51
samza-core/src/test/java/org/apache/samza/container/grouper/task/TestTaskAssignmentManager.java d813fdcd17b963321df4a57708710c9e5a20aa92
Diff: https://reviews.apache.org/r/51824/diff/
Testing
-------
`./gradlew build` succeeds, and all unit tests pass
Thanks,
Jagadish Venkatraman
Re: Review Request 51824: SAMZA-1016 Fix support for 'joint
compilation' of scala and java sources
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51824/
-----------------------------------------------------------
(Updated Sept. 12, 2016, 9:23 p.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Ramesh, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description (updated)
-------
The Samza gradle settings are not setup correctly for joint compilation of Java and Scala. When javac runs before scalac, the .java files that import scala classes will fail compilation. This is because scalac has not run (and hence, has not compiled the imported scala sources to class files). The reverse problem occurs when scalac is run before javac - ie. the .scala files that import java classes will fail compilation.
"Joint compilation" refers to compiling scala and java as a single compilation unit. This will run the `scala` plugin to joint compile both java and scala sources.
This relies on SAMZA-1015 (https://reviews.apache.org/r/51819/) to be committed first
Diffs
-----
build.gradle 004c81e9173c22dee3e282aad2a58a34a3e46fe2
checkstyle/checkstyle.xml 770b5e7f7a091198bbf53b3908600f9ac0caa4c7
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
samza-core/src/test/java/org/apache/samza/container/TestLocalityManager.java 9661885c1278c0d1cf53aae61f502ae719adfd51
samza-core/src/test/java/org/apache/samza/container/grouper/task/TestTaskAssignmentManager.java d813fdcd17b963321df4a57708710c9e5a20aa92
Diff: https://reviews.apache.org/r/51824/diff/
Testing
-------
`./gradlew build` succeeds, and all unit tests pass
Thanks,
Jagadish Venkatraman
Re: Review Request 51824: SAMZA-1016 Fix support for 'joint
compilation' of scala and java sources
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51824/
-----------------------------------------------------------
(Updated Sept. 12, 2016, 9:21 p.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Ramesh, Xinyu Liu, and Yi Pan (Data Infrastructure).
Repository: samza
Description (updated)
-------
The Samza gradle settings are not setup correctly for joint compilation of Java and Scala. When javac runs before scalac, the .java files that import scala classes will fail compilation. This is because scalac has not run (and hence, has not compiled the imported scala sources to class files). The reverse problem occurs when scalac is run before javac - ie. the .scala files that import java classes will fail compilation.
"Joint compilation" refers to compiling scala and java as a single compilation unit. This will run the `scala` plugin to joint compile both java and scala sources.
Diffs
-----
build.gradle 004c81e9173c22dee3e282aad2a58a34a3e46fe2
checkstyle/checkstyle.xml 770b5e7f7a091198bbf53b3908600f9ac0caa4c7
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
samza-core/src/test/java/org/apache/samza/container/TestLocalityManager.java 9661885c1278c0d1cf53aae61f502ae719adfd51
samza-core/src/test/java/org/apache/samza/container/grouper/task/TestTaskAssignmentManager.java d813fdcd17b963321df4a57708710c9e5a20aa92
Diff: https://reviews.apache.org/r/51824/diff/
Testing
-------
`./gradlew build` succeeds, and all unit tests pass
Thanks,
Jagadish Venkatraman