You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/21 19:27:12 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #10996: Kubernetes executor ha

dimberman commented on a change in pull request #10996:
URL: https://github.com/apache/airflow/pull/10996#discussion_r492295346



##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -318,7 +320,8 @@ def __init__(self,
         self.kube_watcher = self._make_kube_watcher()
 
     def _make_kube_watcher(self) -> KubernetesJobWatcher:
-        resource_version = KubeResourceVersion.get_current_resource_version()
+        global global_resource_version  # pylint: disable = global-statement

Review comment:
       @ashb the hard art is the fact that the K8sExecutor is split across 3 separate classes. I can't figure out if a Singleton would be more or less antipattern.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org