You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "BlackPigHe (via GitHub)" <gi...@apache.org> on 2024/01/16 06:23:28 UTC
[PR] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
BlackPigHe opened a new pull request, #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89
[hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458044896
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oracle/dialect/OraclePreparedStatementTest.java:
##########
@@ -48,10 +48,10 @@ void testInsertStatement() {
String insertStmt = dialect.getInsertIntoStatement(tableName, fieldNames);
assertThat(insertStmt)
.isEqualTo(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
+ "VALUES (:id, :name, :email, :ts, :field1, :field_2, :__field_3__)");
NamedStatementMatcher.parsedSql(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
Review Comment:
In issue description it was only something about table name
why does it impact columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "fengzhi09 (via GitHub)" <gi...@apache.org>.
fengzhi09 commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-3664504004
## English Version
**Title**: PostgresDialect fails to quote reserved keywords (e.g., `desc`) in column names, causing SQL syntax errors
**Body**:
I encountered an issue when using the Flink JDBC connector to write data into a PostgreSQL table that contains a column named `desc` — which is a reserved keyword in PostgreSQL. The operation fails with the following error:
```
ERROR: syntax error at or near "desc"
Position: 49
```
Upon investigation, I found that the generated SQL statement does **not** wrap the column name `desc` in double quotes (i.e., it should be `"desc"`). In PostgreSQL, reserved keywords must be quoted with double quotes to be used as identifiers.
Looking at the source code, I noticed that `PostgresDialect` does **not** override the `quoteIdentifier` method like other dialects (e.g., MySQLDialect, OracleDialect). As a result, column names are inserted into SQL statements verbatim, leading to syntax errors when they conflict with reserved words.
**Suggestion**:
Please implement the `quoteIdentifier` method in `PostgresDialect` to properly quote all column names (or at least reserved keywords) using double quotes, ensuring compatibility with PostgreSQL’s identifier rules.
Relevant code location:
https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/PostgresDialect.java
<img width="1850" height="844" alt="image" src="https://github.com/user-attachments/assets/c8907648-1f96-48fc-b30f-10686f6d7a56" />
## 中文版本
**标题**：PostgreSQL 方言未正确转义保留关键字字段（如 `desc`），导致 INSERT/UPDATE 语句语法错误
**正文**：
我在使用 Flink JDBC connector 写入 PostgreSQL 表时遇到了一个问题：当表中包含名为 `desc` 的列（PostgreSQL 保留关键字）时，写入操作失败，报错如下：
```
ERROR: syntax error at or near "desc"
Position: 49
```
经排查，Flink 生成的 SQL 语句未对列名 `desc` 进行双引号转义（即应写作 `"desc"`），而 PostgreSQL 要求保留关键字必须用双引号引用才能作为标识符使用。
我查看了源码，发现 `PostgresDialect` 并未像其他数据库方言（如 MySQL、Oracle）那样重写 `quoteIdentifier` 方法来自动处理此类保留字。这导致在构建 INSERT 或 ON CONFLICT ... DO UPDATE 语句时，直接使用了原始列名，从而引发语法错误。
**建议**：
请为 `PostgresDialect` 实现 `quoteIdentifier` 方法，对所有列名统一使用双引号包裹（或至少对保留关键字进行转义），以确保与 PostgreSQL 的兼容性。
相关代码位置参考：
https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/PostgresDialect.java
<img width="1850" height="844" alt="image" src="https://github.com/user-attachments/assets/c8907648-1f96-48fc-b30f-10686f6d7a56" />
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458591446
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oracle/dialect/OraclePreparedStatementTest.java:
##########
@@ -48,10 +48,10 @@ void testInsertStatement() {
String insertStmt = dialect.getInsertIntoStatement(tableName, fieldNames);
assertThat(insertStmt)
.isEqualTo(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
+ "VALUES (:id, :name, :email, :ts, :field1, :field_2, :__field_3__)");
NamedStatementMatcher.parsedSql(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
Review Comment:
can we have a failing test reproducing the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1893138077
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1900023171
> > I guess we can extract information about current quote identifier directly from JDBCDriver `java.sql.DatabaseMetaData#getIdentifierQuoteString` and then we don't need to hardcode it for every dialect
>
> I get it. If there are no compatibility issues, It's better this way.
I just had a look at it and found that the interface was in the test package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1920669676
yep, may be it is a point to see whether we could adapt it or not
btw I haven't found any test reproducing the issue, can you add one?
Also I would say the issue is more complex than just adding sql quote identifiers
e.g. even though there are quotes queries with fields containing question marks `?` will fail FLINK-34211
i guess we need to a have a number of dedicated tests for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-4266034910
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458591446
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oracle/dialect/OraclePreparedStatementTest.java:
##########
@@ -48,10 +48,10 @@ void testInsertStatement() {
String insertStmt = dialect.getInsertIntoStatement(tableName, fieldNames);
assertThat(insertStmt)
.isEqualTo(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
+ "VALUES (:id, :name, :email, :ts, :field1, :field_2, :__field_3__)");
NamedStatementMatcher.parsedSql(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
Review Comment:
can we have a a filaing test reproducing the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #89: [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver.
URL: https://github.com/apache/flink-connector-jdbc/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1894792756
add the commit to update test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1900005162
> I guess we can extract information about current quote identifier directly from JDBCDriver `java.sql.DatabaseMetaData#getIdentifierQuoteString` and then we don't need to hardcode it for every dialect
I get it. If there are no compatibility issues, It's better this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458592157
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java:
##########
@@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row row, int[] pkFields) {
}
return pkRow;
}
+
+ public static String handleDoubleQuotes(String identifier) {
+ String[] split = identifier.split("\\.");
+ StringBuilder builder = new StringBuilder();
+ for (String s : split) {
+ builder.append("\"").append(s).append("\"");
+ builder.append(".");
+ }
+ return builder.deleteCharAt(builder.length() - 1).toString();
+ }
Review Comment:
Do you think that the location of this method is not appropriate, I think it is OK, the specific escape characters of the data source in their own package implementation, there are public features to extract and did not find a better location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458576939
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java:
##########
@@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row row, int[] pkFields) {
}
return pkRow;
}
+
+ public static String handleDoubleQuotes(String identifier) {
+ String[] split = identifier.split("\\.");
+ StringBuilder builder = new StringBuilder();
+ for (String s : split) {
+ builder.append("\"").append(s).append("\"");
+ builder.append(".");
+ }
+ return builder.deleteCharAt(builder.length() - 1).toString();
+ }
Review Comment:
Because oracle and postgres have the same escape characters, It's all double quotes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-3591042001
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458035878
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java:
##########
@@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row row, int[] pkFields) {
}
return pkRow;
}
+
+ public static String handleDoubleQuotes(String identifier) {
+ String[] split = identifier.split("\\.");
+ StringBuilder builder = new StringBuilder();
+ for (String s : split) {
+ builder.append("\"").append(s).append("\"");
+ builder.append(".");
+ }
+ return builder.deleteCharAt(builder.length() - 1).toString();
+ }
Review Comment:
I didn't get why we are going to put logic with double quotes into some generic place if for different engines there could be different quotes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458581313
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oracle/dialect/OraclePreparedStatementTest.java:
##########
@@ -48,10 +48,10 @@ void testInsertStatement() {
String insertStmt = dialect.getInsertIntoStatement(tableName, fieldNames);
assertThat(insertStmt)
.isEqualTo(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
+ "VALUES (:id, :name, :email, :ts, :field1, :field_2, :__field_3__)");
NamedStatementMatcher.parsedSql(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2, __field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\", \"ts\", \"field1\", \"field_2\", \"__field_3__\") "
Review Comment:
the method ‘quoteIdentifier’ is common，column metadata is also by call the method.Columns should have this problem as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458585157
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java:
##########
@@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row row, int[] pkFields) {
}
return pkRow;
}
+
+ public static String handleDoubleQuotes(String identifier) {
+ String[] split = identifier.split("\\.");
+ StringBuilder builder = new StringBuilder();
+ for (String s : split) {
+ builder.append("\"").append(s).append("\"");
+ builder.append(".");
+ }
+ return builder.deleteCharAt(builder.length() - 1).toString();
+ }
Review Comment:
this package is not only for oracle and postgres. E.g. MS SQL Server, MySQL are different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1899991985
I guess we can extract information about current quote identifier directly from JDBCDriver
`java.sql.DatabaseMetaData#getIdentifierQuoteString`
and then we don't need to hardcode it for every dialect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1900051746
> quote identifier
I thought the method `Java.SQL.DatabaseMetaData#getIdentifierQuoteString` to dynamically access quote identifier, the price is too big, need to introduce Connection object which is very heavy, It is not reasonable for the existing dialect class design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34088] [hotfix] fix the problems with special table name characters of postgres and oracle and sqlserver. [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #89:
URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1900001300
> I guess we can extract information about current quote identifier directly from JDBCDriver `java.sql.DatabaseMetaData#getIdentifierQuoteString` and then we don't need to hardcode it for every dialect
In this case, special characters of various data sources need to be preset, and the workload is relatively large
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org