You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/01/30 03:12:14 UTC

Review Request 30439: Increased the default AWAIT timeout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30439/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

I've observed a number of CI VM stalls that lead to test failures, this is an attempt to mitigate some of the flaky tests in the face of VM stalls.


Diffs
-----

  3rdparty/libprocess/include/process/gtest.hpp 10f991d4e6a6ec8479f342ee812faa3f5c3870bb 

Diff: https://reviews.apache.org/r/30439/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 30439: Increased the default AWAIT timeout.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30439/#review72500
-----------------------------------------------------------


Would it not be a bit easier to maintain if we used a single constant (const, getter or define) for introducing such global change?

- Till Toenshoff


On Jan. 30, 2015, 2:12 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30439/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I've observed a number of CI VM stalls that lead to test failures, this is an attempt to mitigate some of the flaky tests in the face of VM stalls.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 10f991d4e6a6ec8479f342ee812faa3f5c3870bb 
> 
> Diff: https://reviews.apache.org/r/30439/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 30439: Increased the default AWAIT timeout.

Posted by Benjamin Mahler <be...@gmail.com>.
Weird, this was ok last night, but I see now that the repository is set as
mesos-incubating. Deleted my incubating remote from git and re-posted here:

https://reviews.apache.org/r/30463/diff/#

I see cody also has this problem:

https://reviews.apache.org/r/30441/diff/#

On Fri, Jan 30, 2015 at 10:42 AM, Vinod Kone <vi...@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30439/
>
> Unable to load the diff?
>
>
> - Vinod Kone
>
> On January 30th, 2015, 2:12 a.m. UTC, Ben Mahler wrote:
>   Review request for mesos and Vinod Kone.
> By Ben Mahler.
>
> *Updated Jan. 30, 2015, 2:12 a.m.*
>  *Repository: * mesos-incubating
> Description
>
> I've observed a number of CI VM stalls that lead to test failures, this is an attempt to mitigate some of the flaky tests in the face of VM stalls.
>
>   Testing
>
> make check
>
>   Diffs
>
>    - 3rdparty/libprocess/include/process/gtest.hpp
>    (10f991d4e6a6ec8479f342ee812faa3f5c3870bb)
>
> View Diff <https://reviews.apache.org/r/30439/diff/>
>

Re: Review Request 30439: Increased the default AWAIT timeout.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30439/#review70391
-----------------------------------------------------------


Unable to load the diff?

- Vinod Kone


On Jan. 30, 2015, 2:12 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30439/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> I've observed a number of CI VM stalls that lead to test failures, this is an attempt to mitigate some of the flaky tests in the face of VM stalls.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 10f991d4e6a6ec8479f342ee812faa3f5c3870bb 
> 
> Diff: https://reviews.apache.org/r/30439/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 30439: Increased the default AWAIT timeout.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30439/#review70311
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30439]

All tests passed.

- Mesos ReviewBot


On Jan. 30, 2015, 2:12 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30439/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 2:12 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> I've observed a number of CI VM stalls that lead to test failures, this is an attempt to mitigate some of the flaky tests in the face of VM stalls.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 10f991d4e6a6ec8479f342ee812faa3f5c3870bb 
> 
> Diff: https://reviews.apache.org/r/30439/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>