You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/02/16 18:26:54 UTC
[GitHub] [tomcat] bohmber opened a new pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
bohmber opened a new pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244
…t really shell frendly for unix environments. The class should not a inner class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r381973896
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+/**
+ * A {@link org.apache.tomcat.util.IntrospectionUtils.SecurePropertySource} that uses environment variables to resolve expressions.
+ *
+ * <p><strong>Usage example:</strong></p>
+ *
+ * Configure the certificate with environment variables.
+ *
+ * <pre>
+ * {@code
+ * <SSLHostConfig>
+ * <Certificate certificateKeyFile="${CERTIFICATE_KEY_FILE}"
+ * certificateFile="${CERTIFICATE_FILE}"
+ * certificateChainFile="${CERTIFICATE_CHAIN_FILE}"
+ * type="RSA" />
+ * </SSLHostConfig> }
+ * </pre>
+ *
+ * How to configure:
+ * <pre>
+ * {@code
+ * echo "org.apache.tomcat.util.digester.EnvironmentPropertySource=org.apache.tomcat.util.digester.EnvironmentPropertySource" >> conf/catalina.properties}
Review comment:
good catch fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586865680
Just curious: why does it have to be Shell friendly ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r380774990
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+public class EnvironmentPropertySource implements IntrospectionUtils.SecurePropertySource {
Review comment:
Since you are doing a bit of re-factoring, could you add some javadoc? Your use of the class suggests that you understand its use and the need for its existence. No need for anything fancy. Just a one or two sentence description and maybe a reference to the users manual if appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-591324659
Ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586870673
If you set it via CATALINA_OPTS is almost impossible to set this value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-589002119
> If we are going to make this change then it makes sense to do it for `org.apache.tomcat.util.digester.Digester.SystemPropertySource` as well.
That is the default implementation and it's always configured. It's a private class the change there is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r381978989
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+/**
+ * A {@link org.apache.tomcat.util.IntrospectionUtils.SecurePropertySource} that uses environment variables to resolve expressions.
+ *
+ * <p><strong>Usage example:</strong></p>
+ *
+ * Configure the certificate with environment variables.
+ *
+ * <pre>
+ * {@code
+ * <SSLHostConfig>
+ * <Certificate certificateKeyFile="${CERTIFICATE_KEY_FILE}"
+ * certificateFile="${CERTIFICATE_FILE}"
+ * certificateChainFile="${CERTIFICATE_CHAIN_FILE}"
+ * type="RSA" />
+ * </SSLHostConfig> }
+ * </pre>
+ *
+ * How to configure:
Review comment:
Both samples to setup the PROPERTY_SOURCE below do not use environment variable. IMO both of them would be picked up by SystemPropertySource, not by EnvironmentPropertySource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g edited a comment on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586889945
I meant _quote_ it, e.g. `-Dsome.key="Some$Value"`, not _escape_ it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586890634
The only reliable way was to add this to catalina.properties. Please test it yourself. I still belief it's a really bad idea to use '$' in a classname that is configurable via -D command line parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r381977791
##########
File path: webapps/docs/changelog.xml
##########
@@ -92,6 +92,10 @@
<fix>
Missing store config attributes for Resources elements. (remm)
</fix>
+ <scode>
+ Rename <code>org.apache.tomcat.util.digester.Digester$EnvironmentPropertySource</code> to
+ <code>org.apache.tomcat.util.digester.EnvironmentPropertySource</code> old class is still available.
Review comment:
Punctuation is missing before ` old class is ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r381956884
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+public class EnvironmentPropertySource implements IntrospectionUtils.SecurePropertySource {
Review comment:
Can you take a look please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r381961119
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+/**
+ * A {@link org.apache.tomcat.util.IntrospectionUtils.SecurePropertySource} that uses environment variables to resolve expressions.
+ *
+ * <p><strong>Usage example:</strong></p>
+ *
+ * Configure the certificate with environment variables.
+ *
+ * <pre>
+ * {@code
+ * <SSLHostConfig>
+ * <Certificate certificateKeyFile="${CERTIFICATE_KEY_FILE}"
+ * certificateFile="${CERTIFICATE_FILE}"
+ * certificateChainFile="${CERTIFICATE_CHAIN_FILE}"
+ * type="RSA" />
+ * </SSLHostConfig> }
+ * </pre>
+ *
+ * How to configure:
+ * <pre>
+ * {@code
+ * echo "org.apache.tomcat.util.digester.EnvironmentPropertySource=org.apache.tomcat.util.digester.EnvironmentPropertySource" >> conf/catalina.properties}
Review comment:
Are you sure that this is the right key ?
Looking at org.apache.tomcat.util.digester.Digester I see:
```
String className = System.getProperty("org.apache.tomcat.util.digester.PROPERTY_SOURCE");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r381978989
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+/**
+ * A {@link org.apache.tomcat.util.IntrospectionUtils.SecurePropertySource} that uses environment variables to resolve expressions.
+ *
+ * <p><strong>Usage example:</strong></p>
+ *
+ * Configure the certificate with environment variables.
+ *
+ * <pre>
+ * {@code
+ * <SSLHostConfig>
+ * <Certificate certificateKeyFile="${CERTIFICATE_KEY_FILE}"
+ * certificateFile="${CERTIFICATE_FILE}"
+ * certificateChainFile="${CERTIFICATE_CHAIN_FILE}"
+ * type="RSA" />
+ * </SSLHostConfig> }
+ * </pre>
+ *
+ * How to configure:
Review comment:
Both samples to setup the PROPERTY_SOURCE below do not use environment variable. IMO both of them would be picked up by SystemPropertySource, not by EnvironmentPropertySource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586880522
I haven't needed to set this particular class but usually one just needs to quote such values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] hamza86 commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
hamza86 commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-591900457
I was trying to use this feature on Tomcat 9.x and from my experience, I found it briefly documented. This feature is really important to run legacy apps on Kubernetes since most of the configurations are coming from config maps.
What I would do, is to create one class that read properties form system properties and environment properties. Ofc a priority mechanism must be introduced to avoid overlapping/overriding properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
markt-asf merged pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-588991284
If we are going to make this change then it makes sense to do it for `org.apache.tomcat.util.digester.Digester.SystemPropertySource` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on a change in pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#discussion_r380866275
##########
File path: java/org/apache/tomcat/util/digester/EnvironmentPropertySource.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.digester;
+
+import java.security.Permission;
+
+import org.apache.tomcat.util.IntrospectionUtils;
+import org.apache.tomcat.util.security.PermissionCheck;
+
+public class EnvironmentPropertySource implements IntrospectionUtils.SecurePropertySource {
Review comment:
Super idea will do it. Give me time til Friday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586885144
> I haven't needed to set this particular class but usually one just needs to quote such values.
Did you try to quote it? I don't know how many \\\\\\ are needed until it's working this is not reliable. Therefore a '$' should be avoided if you are using a shell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586891816
I am not against using a proper class! I'm just trying to understand what kind of problem you have faced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…
URL: https://github.com/apache/tomcat/pull/244#issuecomment-586889945
I meant quote it, e.g. `-Dsome.key="Some$Value"`, not _escape_ it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org