You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/05/13 12:26:03 UTC

[GitHub] [drill] oleg-zinovev commented on a change in pull request #2183: DRILL-6547: IllegalStateException: Tried to remove unmanaged buffer in concat function

oleg-zinovev commented on a change in pull request #2183:
URL: https://github.com/apache/drill/pull/2183#discussion_r631771430



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
##########
@@ -1425,7 +1419,7 @@ public void eval() {
       out.buffer = buffer = buffer.reallocIfNeeded((left.end - left.start) + (right.end - right.start));
       out.start = out.end = 0;
 
-      int id = 0;
+      int id;

Review comment:
       In this case, the id variable is also used in the next loop, as a pointer to where to continue writing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org