[GitHub] [pulsar] jerrypeng commented on a change in pull request #10208: Fix Pulsar Function localrun with multiple instances and metrics server is enabled

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #10208:
URL: https://github.com/apache/pulsar/pull/10208#discussion_r612581530



##########
File path: pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -171,7 +172,7 @@ public RuntimeEnv convert(String value) {
     protected String secretsProviderClassName;
     @Parameter(names = "--secretsProviderConfig", description = "Whats the config for the secrets provider", hidden = true)
     protected String secretsProviderConfig;
-    @Parameter(names = "--metricsPortStart", description = "The starting port range for metrics server", hidden = true)
+    @Parameter(names = "--metricsPortStart", description = "The starting port range for metrics server. When running instances as threads, one metrics server is used to host the stats for all instances.", hidden = true)

Review comment:
       For running instances in process mode i.e. each instance is a separate JVM processes, the port range is needed as each instance will run its own metrics server on the specified port in its own respective process




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org