You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/23 15:05:26 UTC

[GitHub] [flink] pnowojski opened a new pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

pnowojski opened a new pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935
 
 
   This PR exposes the new `checkpointStartDelayNanos` metric in the WebUI.
   
   Screenshot of how does the proposed change look like can be found in the [ticket](https://issues.apache.org/jira/browse/FLINK-15603).
   
   ## Verifying this change
   
   This change is covered by some existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145895126 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145895126) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-579272380
 
 
   Thanks for pointing this out @vthinkxie. I've added a single line entry in the `src/app/interfaces/job-checkpoint.ts`. Is that what you had in mind?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145895126 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145895126) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145895126 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:aff25d3c53871ca327c5587fca5754b43ca7b398 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:aff25d3c53871ca327c5587fca5754b43ca7b398
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145895126) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592) 
   * aff25d3c53871ca327c5587fca5754b43ca7b398 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145895126 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145895126) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-579291876
 
 
   Thank you all the reviews :) Will merge it with green travis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#discussion_r371836089
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
 ##########
 @@ -164,6 +164,7 @@ export interface CheckPointSubTaskInterface {
       buffered: CheckPointMinMaxAvgStatisticsInterface;
       duration: CheckPointMinMaxAvgStatisticsInterface;
     };
+    start_delay: CheckPointMinMaxAvgStatisticsInterface;
 
 Review comment:
   Thanks for pointing this out @vthinkxie. I've added a single line entry in the `src/app/interfaces/job-checkpoint.ts`. Is that what you had in mind?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577722314
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d23cbb62a92aeacecabdad080c3d062dcaa7ddba (Thu Jan 23 15:08:11 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#discussion_r370724654
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/TaskCheckpointStatisticDetailsHandler.java
 ##########
 @@ -184,7 +179,8 @@ private static TaskCheckpointStatisticsWithSubtaskDetails createCheckpointDetail
 						subtask.getAsyncCheckpointDuration()),
 					new SubtaskCheckpointStatistics.CompletedSubtaskCheckpointStatistics.CheckpointAlignment(
 						subtask.getAlignmentBuffered(),
-						subtask.getAlignmentDuration())
+						subtask.getAlignmentDuration()),
+					subtask.getCheckpointStartDelay()
 
 Review comment:
   nit: indent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski merged pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145895126 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:aff25d3c53871ca327c5587fca5754b43ca7b398 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146409175 TriggerType:PUSH TriggerID:aff25d3c53871ca327c5587fca5754b43ca7b398
   Hash:aff25d3c53871ca327c5587fca5754b43ca7b398 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4639 TriggerType:PUSH TriggerID:aff25d3c53871ca327c5587fca5754b43ca7b398
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145895126) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592) 
   * aff25d3c53871ca327c5587fca5754b43ca7b398 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146409175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4639) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145895126 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592 TriggerType:PUSH TriggerID:a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77
   Hash:aff25d3c53871ca327c5587fca5754b43ca7b398 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146409175 TriggerType:PUSH TriggerID:aff25d3c53871ca327c5587fca5754b43ca7b398
   Hash:aff25d3c53871ca327c5587fca5754b43ca7b398 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4639 TriggerType:PUSH TriggerID:aff25d3c53871ca327c5587fca5754b43ca7b398
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   * a7a9018a455af8dd7bbff05eae6c5fc7c00f7a77 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145895126) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4592) 
   * aff25d3c53871ca327c5587fca5754b43ca7b398 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146409175) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4639) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] vthinkxie commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#discussion_r371857640
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-checkpoint.ts
 ##########
 @@ -164,6 +164,7 @@ export interface CheckPointSubTaskInterface {
       buffered: CheckPointMinMaxAvgStatisticsInterface;
       duration: CheckPointMinMaxAvgStatisticsInterface;
     };
+    start_delay: CheckPointMinMaxAvgStatisticsInterface;
 
 Review comment:
   lgtm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#discussion_r371832317
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/checkpoints/TaskCheckpointStatisticDetailsHandler.java
 ##########
 @@ -184,7 +179,8 @@ private static TaskCheckpointStatisticsWithSubtaskDetails createCheckpointDetail
 						subtask.getAsyncCheckpointDuration()),
 					new SubtaskCheckpointStatistics.CompletedSubtaskCheckpointStatistics.CheckpointAlignment(
 						subtask.getAlignmentBuffered(),
-						subtask.getAlignmentDuration())
+						subtask.getAlignmentDuration()),
+					subtask.getCheckpointStartDelay()
 
 Review comment:
   ? I think it's indented correctly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] AHeise commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#discussion_r370724924
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/MinMaxAvgStatistics.java
 ##########
 @@ -43,6 +45,13 @@
 	@JsonProperty(FIELD_NAME_AVERAGE)
 	private final long average;
 
+	public static MinMaxAvgStatistics createFrom(MinMaxAvgStats stats) {
 
 Review comment:
   nit: java natives would just use `of` or `valueOf`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-579272380
 
 
   I've addressed the comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577722243
 
 
   CC @vthinkxie 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10935: [FLINK-15603][web] Expose checkpointStartDelayNanos metric in the WebUI
URL: https://github.com/apache/flink/pull/10935#issuecomment-577747488
 
 
   <!--
   Meta data
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145789039 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   Hash:d23cbb62a92aeacecabdad080c3d062dcaa7ddba Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586 TriggerType:PUSH TriggerID:d23cbb62a92aeacecabdad080c3d062dcaa7ddba
   -->
   ## CI report:
   
   * d23cbb62a92aeacecabdad080c3d062dcaa7ddba Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145789039) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4586) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services