You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2008/05/09 18:06:55 UTC

[jira] Created: (JCR-1590) JSR 283: Locking

JSR 283: Locking
----------------

                 Key: JCR-1590
                 URL: https://issues.apache.org/jira/browse/JCR-1590
             Project: Jackrabbit
          Issue Type: Sub-task
            Reporter: angela




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661952#action_12661952 ] 

angela commented on JCR-1590:
-----------------------------

rev r732693:

- added LockManager implementation (SessionLockManager)
- moved code from deprecated lock related methods from NodeImpl to LockManager
- changed lockOwner according to jsr 283 semantics 
- some preparations for specifying lock timeout (currently timeout hints are ignored however)
- lock related properties are written on state level directly omitting any transient modifications

TODOs:
- timeout
- lock token handling
- enable tests
- adjust TCK tests

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645465#action_12645465 ] 

angela commented on JCR-1590:
-----------------------------

initial steps:
- add extensions to Lock.java and new interface LockManager.java to jackrabbit-api/.../jsr283/lock
- let LockImpl implement the extended Lock
- add TODOs for the changes to be made to LockImpl for 2.0

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742419#action_12742419 ] 

Jukka Zitting commented on JCR-1590:
------------------------------------

Added the failure node path (when easily available) to LockExceptions in revisions 803549 and 803566.

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-1590:
------------------------

      Component/s: JCR 2.0
    Fix Version/s: 2.0.0

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681697#action_12681697 ] 

angela commented on JCR-1590:
-----------------------------

rev. 753228

jackrabbit-api

- update Lock.java (getSecondsRemaining throws RepositoryException)
- add Workspace.java 

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1590) JSR 283: Locking

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1590.
--------------------------------

    Resolution: Fixed

Added a simple lock timeout mechanism and updated the related TCK tests in revision 805431.

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681713#action_12681713 ] 

angela edited comment on JCR-1590 at 4/7/09 7:19 AM:
-----------------------------------------------------

rev. 753244  

- session-scoped locks must not expose the lock token
  -> see also changes made to jackrabbit-spi, jackrabbit-jcr2spi and spi-impls
- WorkspaceImpl implements the 283-Workspace
  -> renamed the implementation specific getLockManager method to getInternalLockManager
  -> and changed its usage accordingly
- getSecondsRemaining returns a negative number if the lock has expired or was released.

TODO:

- timeout 
- adjust/review TCK tests and merge with 283 tests 
- LockException should have the failure-node-path set

      was (Author: anchela):
    rev. 753244  

- session-scoped locks must not expose the lock token
  -> see also changes made to jackrabbit-spi, jackrabbit-jcr2spi and spi-impls
- WorkspaceImpl implements the 283-Workspace
  -> renamed the implementation specific getLockManager method to getInternalLockManager
  -> and changed its usage accordingly
- getSecondsRemaining returns a negative number if the lock has expired or was released.

TODO:

- timeout 
- adjust/review TCK tests and merge with 283 tests 
  
> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681713#action_12681713 ] 

angela commented on JCR-1590:
-----------------------------

rev. 753244  

- session-scoped locks must not expose the lock token
  -> see also changes made to jackrabbit-spi, jackrabbit-jcr2spi and spi-impls
- WorkspaceImpl implements the 283-Workspace
  -> renamed the implementation specific getLockManager method to getInternalLockManager
  -> and changed its usage accordingly
- getSecondsRemaining returns a negative number if the lock has expired or was released.

TODO:

- timeout 
- adjust/review TCK tests and merge with 283 tests 

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741287#action_12741287 ] 

Jukka Zitting commented on JCR-1590:
------------------------------------

Thanks for the list of TODOs and the status update on dev@. I'll give a look at the remaining items in the next few days.

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1590) JSR 283: Locking

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666153#action_12666153 ] 

angela commented on JCR-1590:
-----------------------------

rev 736658:

- lock token handling

TODOs:
- timeout 
- session-scoped locks must not expose the lock token
  uncommenting that needs some more adjustments in jcr2spi and the spi
- adjust/review TCK tests and merge with 283 tests

> JSR 283: Locking
> ----------------
>
>                 Key: JCR-1590
>                 URL: https://issues.apache.org/jira/browse/JCR-1590
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: JCR 2.0
>            Reporter: angela
>             Fix For: 2.0.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.